Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Bitcoin Qt/Gui changes up to 0.14.x part 3 #1617

Merged
merged 19 commits into from
Sep 11, 2017

Commits on Sep 9, 2017

  1. Merge bitcoin#8996: Network activity toggle

    19f46f1 Qt: New network_disabled icon (Luke Dashjr)
    54cf997 RPC/Net: Use boolean consistently for networkactive, and remove from getinfo (Luke Dashjr)
    b2b33d9 Overhaul network activity toggle (Jonas Schnelli)
    32efa79 Qt: Add GUI feedback and control of network activity state. (Jon Lund Steffensen)
    e38993b RPC: Add "togglenetwork" method to toggle network activity temporarily (Jon Lund Steffensen)
    7c9a98a Allow network activity to be temporarily suspended. (Jon Lund Steffensen)
    jonasschnelli authored and codablock committed Sep 9, 2017
    Configuration menu
    Copy the full SHA
    943650b View commit details
    Browse the repository at this point in the history
  2. Revert on-click behavior of network status icon to showing peers list

    Stay with the way Dash handled clicking on the status icon
    codablock committed Sep 9, 2017
    Configuration menu
    Copy the full SHA
    8a04c20 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2017

  1. Configuration menu
    Copy the full SHA
    064e6cd View commit details
    Browse the repository at this point in the history
  2. Use UniValue until bitcoin PR bitcoin#8788 is backported

    Network active toggle was already based on
    "[RPC] Give RPC commands more information about the RPC request"
    We need to use the old UniValue style until that one is backported
    codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    b4bd44b View commit details
    Browse the repository at this point in the history
  3. Merge bitcoin#9190: qt: Plug many memory leaks

    ed998ea qt: Avoid OpenSSL certstore-related memory leak (Wladimir J. van der Laan)
    5204598 qt: Avoid shutdownwindow-related memory leak (Wladimir J. van der Laan)
    e4f126a qt: Avoid splash-screen related memory leak (Wladimir J. van der Laan)
    693384e qt: Prevent thread/memory leak on exiting RPCConsole (Wladimir J. van der Laan)
    47db075 qt: Plug many memory leaks (Wladimir J. van der Laan)
    laanwj authored and codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    fee9bf3 View commit details
    Browse the repository at this point in the history
  4. Merge bitcoin#9218: qt: Show progress overlay when clicking spinner icon

    042f9fa qt: Show progress overlay when clicking spinner icon (Wladimir J. van der Laan)
    827d9a3 qt: Replace NetworkToggleStatusBarControl with generic ClickableLabel (Wladimir J. van der Laan)
    jonasschnelli authored and codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    6336ac1 View commit details
    Browse the repository at this point in the history
  5. Merge bitcoin#8874: Multiple Selection for peer and ban tables

    1077577 Fix auto-deselection of peers (Andrew Chow)
    addfdeb Multiple Selection for peer and ban tables (Andrew Chow)
    laanwj authored and codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    23fb5b6 View commit details
    Browse the repository at this point in the history
  6. Merge bitcoin#9266: Bugfix: Qt/RPCConsole: Put column enum in the rig…

    …ht places
    
    df17fe0 Bugfix: Qt/RPCConsole: Put column enum in the right places (Luke Dashjr)
    laanwj authored and codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    67e317c View commit details
    Browse the repository at this point in the history
  7. Merge bitcoin#9255: qt: layoutAboutToChange signal is called layoutAb…

    …outToBeChanged
    
    f36349e qt: Remove on_toggleNetworkActiveButton_clicked from RPCConsole (Wladimir J. van der Laan)
    297cc20 qt: layoutAboutToChange signal is called layoutAboutToBeChanged (Wladimir J. van der Laan)
    laanwj authored and codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    8b3699d View commit details
    Browse the repository at this point in the history
  8. Merge bitcoin#9461: [Qt] Improve progress display during headers-sync…

    … and peer-finding
    
    40ec7c7 [Qt] Improve progress display during headers-sync and peer-finding (Jonas Schnelli)
    jonasschnelli authored and codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    ac375a1 View commit details
    Browse the repository at this point in the history
  9. Merge bitcoin#9588: qt: Use nPowTargetSpacing constant

    fa4d478 qt: Use nPowTargetSpacing constant (MarcoFalke)
    jonasschnelli authored and codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    c90944e View commit details
    Browse the repository at this point in the history
  10. Merge bitcoin#9280: [Qt] Show ModalOverlay by pressing the progress b…

    …ar, allow hiding
    
    89a3723 [Qt] Show ModalOverlay by pressing the progress bar, disabled show() in sync mode (Jonas Schnelli)
    jonasschnelli authored and codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    47ee86d View commit details
    Browse the repository at this point in the history
  11. Merge bitcoin#8906: [qt] sync-overlay: Don't show progress twice

    fafeec3 [qt] sync-overlay: Don't show progress twice (MarcoFalke)
    laanwj authored and codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    a9300ba View commit details
    Browse the repository at this point in the history
  12. Merge bitcoin#8985: Use pindexBestHeader instead of setBlockIndexCand…

    …idates for NotifyHeaderTip()
    
    3154d6e [Qt] use NotifyHeaderTip's height and date for the progress update (Jonas Schnelli)
    0a261b6 Use pindexBestHeader instead of setBlockIndexCandidates for NotifyHeaderTip() (Jonas Schnelli)
    jonasschnelli authored and codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    509210a View commit details
    Browse the repository at this point in the history
  13. Hide modal overlay forever when syncing has catched up

    Don't allow to open it again by clicking on the progress bar and spinner
    icon. Currently the overlay does not show meaningful information about
    masternode sync and it gives the impression of being stuck after the block
    chain sync is done.
    codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    0c3b2d7 View commit details
    Browse the repository at this point in the history
  14. Don't include chainparams.h in sendcoinsdialog.cpp

    This was just a remainder of a backported PR which meant to change some
    calculation in this file which does not apply to Dash.
    codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    4f29f0b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c74dfec View commit details
    Browse the repository at this point in the history
  16. Merge bitcoin#9528: [qt] Rename formateNiceTimeOffset(qint64) to form…

    …atNiceTimeOffset(qint64)
    
    988d300 [qt] Rename formateNiceTimeOffset(qint64) to formatNiceTimeOffset(qint64) (practicalswift)
    MarcoFalke authored and codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    75fd0fc View commit details
    Browse the repository at this point in the history
  17. Merge bitcoin#11237: qt: Fixing division by zero in time remaining

    c8d38ab Refactor tipUpdate as per style guide (MeshCollider)
    3b69a08 Fix division by zero in time remaining (MeshCollider)
    
    Pull request description:
    
      Fixes bitcoin#10291, bitcoin#11265
    
      progressDelta may be 0 (or even negative according to 11265), this checks for that and prints unknown if it is, because we cannot calculate an estimate for the time remaining (would be infinite or negative).
    
    Tree-SHA512: bc5708e5ed6e4670d008219558c5fbb25709bd99a32c98ec39bb74f94a0b7fa058f3d03389ccdd39e6723e6b5b48e34b13ceee7c051c2db631e51d8ec3e1d68c
    laanwj authored and codablock committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    1f1a609 View commit details
    Browse the repository at this point in the history