fix: MakeCollateralAmounts stuck sometimes #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
changed the title
eduffield222
pushed a commit
that referenced
this pull request
Feb 7, 2015
fix: MakeCollateralAmounts stuck sometimes
PastaPastaPasta
added a commit
that referenced
this pull request
Jun 10, 2024
…214, #166, #296, #194, #280, #325, partial bitcoin-core/gui#79 (qt backports) ddca614 merge bitcoin-core/gui#325: Align numbers in the "Peer Id" column to the right (Kittywhiskers Van Gogh) 09a8fc1 merge bitcoin-core/gui#280: Remove user input from URI error message (Kittywhiskers Van Gogh) a3ac694 merge bitcoin-core/gui#194: Save/restore RPCConsole geometry only for window (Kittywhiskers Van Gogh) 504f834 merge bitcoin-core/gui#296: Do not use QObject::tr plural syntax for numbers with a unit symbol (Kittywhiskers Van Gogh) c33afea merge bitcoin-core/gui#166: Use enum type as switch argument in *TableModel (Kittywhiskers Van Gogh) 5a67b52 merge bitcoin-core/gui#214: Disable requests context menu actions when appropriate (Kittywhiskers Van Gogh) dc9b25e merge bitcoin-core/gui#219: Prevent the main window popup menu (Kittywhiskers Van Gogh) 7774bdb partial bitcoin-core/gui#79: Embed monospaced font (Kittywhiskers Van Gogh) 722bd8d qt: introduce GUIUtil::fixedPitchFont (Kittywhiskers Van Gogh) afd0648 merge bitcoin-core/gui#179: Add Type column to peers window, update peer details name/tooltip (Kittywhiskers Van Gogh) 57597df merge bitcoin-core/gui#203: Display plain "Inbound" in peer details (Kittywhiskers Van Gogh) 582c6ec merge bitcoin-core/gui#180: connection type follow-ups (Kittywhiskers Van Gogh) Pull request description: ## Additional Information | `develop` (d7413ff) | This PR | | ------------------------------------------------------------ | ------------------------------------------------------------ | |  |  | ## Breaking Changes None expected, changes are limited to refactoring, cleanup and refinement. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK ddca614 Tree-SHA512: 8b07c6261c5e111f6db06be528aab7d3862bb31cf23e7df84a1e211ae1e1b5d52a51a520b24ed1b058ac19f845204fe458f16ba5920db9c1b1d1939a1fff6711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MakeCollateralAmounts stuck sometimes and wouldn't let denominating further because of some outdated logic. All necessary checks are made inside two next if-s with CreateTransaction functions. Cleaned.