Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename nEpochStart variable and adjust comments #1915

Merged
merged 3 commits into from
Feb 12, 2018
Merged

rename nEpochStart variable and adjust comments #1915

merged 3 commits into from
Feb 12, 2018

Conversation

nmarley
Copy link

@nmarley nmarley commented Feb 12, 2018

Seems leftover from some old logic, but nEpochStart isn't technically what this is, nStartHeight seems more accurate. Also, comments are a little off, so cleaned up / removed as necessary.

@nmarley
Copy link
Author

nmarley commented Feb 12, 2018

Upon further consideration, nBlockHeight might be a more suitable variable name, since the superblock is issued at only one single point in time and doesn't really "start" or "end".

@UdjinM6
Copy link

UdjinM6 commented Feb 12, 2018

Yeah, start doesn't sound right here. Same for GetBlockStart().

@nmarley
Copy link
Author

nmarley commented Feb 12, 2018

Agree, blockHeight makes more sense here.

UdjinM6
UdjinM6 approved these changes Feb 12, 2018
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 added this to the 12.3 milestone Feb 12, 2018
@UdjinM6 UdjinM6 merged commit 354aac8 into dashpay:develop Feb 12, 2018
@UdjinM6 UdjinM6 mentioned this pull request Feb 12, 2018
Merged
@nmarley nmarley deleted the rename-trigger-blockheight-var branch February 12, 2018 18:20
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@nmarley @andvgal
rename nEpochStart variable and adjust comments (dashpay#1915)
512c566 
* rename nEpochStart variable and adjust comments

* rename GetBlockStart() -> GetBlockHeight()

* change var name to nBlockHeight
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 28, 2019
@nmarley @CryptoCentric
rename nEpochStart variable and adjust comments (dashpay#1915)
1fce4f3 
* rename nEpochStart variable and adjust comments

* rename GetBlockStart() -> GetBlockHeight()

* change var name to nBlockHeight
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Mar 2, 2019
@nmarley @CryptoCentric
rename nEpochStart variable and adjust comments (dashpay#1915)
7169d5e 
* rename nEpochStart variable and adjust comments

* rename GetBlockStart() -> GetBlockHeight()

* change var name to nBlockHeight
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.3
Development

Successfully merging this pull request may close these issues.
2 participants
@nmarley @UdjinM6