12.3 release notes draft #2045
Merged
12.3 release notes draft #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troydash
reviewed
Apr 24, 2018
doc/release-notes.md
Outdated
| -------------------------------------------- | ||
|
|
||
| We backported many performance improvements from Bitcoin Core and aligned most of our codebase with version 0.14. | ||
| Most notable ones besides various performance and stability imrovements probably are |
codablock
reviewed
Apr 24, 2018
There was a problem hiding this comment.
Proposing a few changes:
codablock@d79c9c0
codablock@2b99c7e
doc/release-notes.md
Outdated
| ------------------------ | ||
|
|
||
| PrivateSend collateral is no longer required to be N times of the PrivateSend fee, instead any input | ||
| which is in the [1..N] range can be used as a collateral. Inputs that are in the [1..2) range will now |
There was a problem hiding this comment.
"Inputs that are in the [1..2) range will" is a bit unclear to me
thephez
reviewed
Apr 24, 2018
doc/release-notes.md
Outdated
| in terms of security and validation - it relies a lot on surrounding nodes, so please keep this in mind if you decide to | ||
| use it for something. | ||
|
|
||
| RPC changes |
There was a problem hiding this comment.
Not sure how comprehensive this is intended to be. Some other RPC items:
getrawmempool's added InstantSend-related infogetgovernanceinfochanged from mnwatchdog->sentinelpinggetgenerate/setgenerateremovedgetaddednodeinfo- dummy parameter removedgetwalletinfo- add PS balance
There was a problem hiding this comment.
- `getgenerate`/`setgenerate` removed
- `getaddednodeinfo` - dummy parameter removed
These two were changed via backports I believe, so shouldn't be in that list imo, but I'll add the rest of the list. Thanks! 👍
thephez
reviewed
Apr 24, 2018
doc/release-notes.md
Outdated
| Also, the devnet name is put into the sub-version of the `VERSION` message. | ||
| If a node connects to the wrong network, it will immediately be disconnected. | ||
|
|
||
| New format of network messsage signatures |
doc/release-notes.md
Outdated
| PrivateSend collateral is no longer required to be N times of the PrivateSend fee, instead any input | ||
| which is in the [1..N] range can be used as a collateral. Inputs that are in the [1..2) range will now | ||
| be used in collaterals with OP_RETURN outputs which will allow such inputs to be completely consumed | ||
| (previousely they were not used at all and instead were kept in wallet and global UTXO forever). |
There was a problem hiding this comment.
previousely -> previously
|
Applied suggested changes, rephrased few confusing parts, updated commit list. |
troydash
reviewed
Apr 24, 2018
doc/release-notes.md
Outdated
| equal 1 PSF but strictly less than 2 PSF will be used in collaterals with OP_RETURN outputs. Note that such | ||
| inputs will be consumed copletely, with no change outputs at all. This should lower number of inputs wallet | ||
| would need to take care of, improve privacy by eleminating the case where user accidentally merge small | ||
| non-private inputs together and also decrease global UTXO set size. |
troydash
reviewed
Apr 24, 2018
doc/release-notes.md
Outdated
| If you rely on the old output format, you can still specify an additional parameter for backwards compatibility (`all` for `count` and `status` for `list`). | ||
| - `masternodelist` has a few new modes: `daemon`, `json`, `sentinel` | ||
| - `debug` rpc now requires categories to be separated via `+`, not `,` like before (e.g. `dash+net`) | ||
| - `getchaintips` now shows the block fork occured in `forkpoint` field |
troydash
reviewed
Apr 24, 2018
| - [`271c249e1`](https://github.com/dashpay/dash/commit/271c249e1) Skip next mn payments winners when selecting a MN to mix on (#1921) | ||
| - [`ca89c7b87`](https://github.com/dashpay/dash/commit/ca89c7b87) [Trivial] Update PrivateSend denominations in comments / typo fixes (#1910) | ||
| - [`b1817dd93`](https://github.com/dashpay/dash/commit/b1817dd93) Introduce CDarksendAccept class (for DSACCEPT messages) (#1875) | ||
| - [`d69ad9d61`](https://github.com/dashpay/dash/commit/d69ad9d61) Skip existing masternode conections on mixing (#1833) |
troydash
reviewed
Apr 24, 2018
| - [`5b1c4d8a1`](https://github.com/dashpay/dash/commit/5b1c4d8a1) Few (mostly trivial) cleanups and fixes (#1940) | ||
| - [`99273f63a`](https://github.com/dashpay/dash/commit/99273f63a) Use SPORK_6_NEW_SIGS to switch from signing string messages to hashes (#1937) | ||
| - [`c65613350`](https://github.com/dashpay/dash/commit/c65613350) Switch masternode id in Dash data structures from CTxIn to COutPoint (#1933) | ||
| - [`2ea6f7d82`](https://github.com/dashpay/dash/commit/2ea6f7d82) Use `override` keyword for overriden class member functions (#1644) |
|
@troydash Fixed typos in text, thanks! Won't fix typos in commit list however because they are buried in git history and they are presented here "as is", so pls just ignore them. |
|
Should include all changes up to planned rc1 now, pls review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
no-squashmerges).This is a WIP and there are still quite a few TODOs. Probably should highlight few most notable backported changes like compact blocks, nulldummy softwork etc. I'm open for suggestions :)