small cleanup in a few places #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Quells warning displayed with `-Wmaybe-uninitialized` flag
This feels like an optimization, something about:
```
if map.count(key)
return false
else
insert(pair)
return true
```
... just feels icky. Plus, `vote.GetMasternodeOutpoint()` is only called
once. The previous version might be slightly more readable, however.
|
Looks good 👍 I'd say it's safe to merge in 12.3 if you drop d7f876e for now. |
|
Per our discussion on another recent PR, we'd like to off on any more non-bug-fixes going in to 12.3, but did you have any specific concerns with commit d7f876e? Or is it just the potential for a bug b/c it's a little more complex? |
It's more like no-new-features-or-potential-changes-in-behaviour mode :) d7f876e looks fine but has a potential to change the behaviour because it touches some actual code unlike others here. |
This reverts commit d7f876e.
|
Yep, makes sense. Might as well get the others in, will revert d7f876e. |
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
* move nStart closer to used and initialize it
* Quells warning displayed with `-Wmaybe-uninitialized` flag
* remove unused mnEntries vectors
* add devnet magic bytes to mininode.py
* remove unused governance-misc.h file
* remove old TODO comments
* replace map count/insert w/emplace in instantx.cpp
This feels like an optimization, something about:
```
if map.count(key)
return false
else
insert(pair)
return true
```
... just feels icky. Plus, `vote.GetMasternodeOutpoint()` is only called
once. The previous version might be slightly more readable, however.
* Revert "replace map count/insert w/emplace in instantx.cpp"
This reverts commit d7f876e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits. Removes unused code, comments, variables, etc.
Let's wait 'til 12.3 is released before any merge, but I've been itching to get this PR created for a while, so gonna go ahead and do that now.