Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: fix wallet lock check in privatesend start #2102

Merged
merged 1 commit into from
Jun 11, 2018
Merged

RPC: fix wallet lock check in privatesend start #2102

merged 1 commit into from
Jun 11, 2018

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jun 7, 2018

Should fail only if locked completely, see https://github.com/dashpay/dash/blob/master/src/wallet/crypter.h#L158-L165 for more info about IsLocked() logic.

Steps to reproduce the issue:

> walletpassphrase "pass" 600 true
> privatesend start
error code: -13
error message:
Error: Please enter the wallet passphrase with walletpassphrase first.
> walletpassphrase "pass" 600 true
error code: -17
error message:
Error: Wallet is already unlocked for mixing only.

Kudos to @thephez for finding the issue 👍

@UdjinM6 UdjinM6 added the bug label Jun 7, 2018
@UdjinM6 UdjinM6 added this to the 12.3 milestone Jun 7, 2018
thephez
thephez approved these changes Jun 8, 2018
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 👍

> walletpassphrase "pass" 600 true
> privatesend start
Mixing started successfully

codablock
codablock approved these changes Jun 11, 2018
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit fcac40a into dashpay:develop Jun 11, 2018
Yoyae pushed a commit to monacocoin-net/monoeci-core that referenced this pull request Jun 12, 2018
@UdjinM6 @Yoyae
RPC: fix wallet lock check in privatesend start (dashpay#2102)
6d8b594
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@UdjinM6 @andvgal
RPC: fix wallet lock check in privatesend start (dashpay#2102)
06810f6
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Mar 1, 2019
@UdjinM6 @CryptoCentric
RPC: fix wallet lock check in privatesend start (dashpay#2102)
29e441a
@UdjinM6 UdjinM6 deleted the fixprivrpc branch November 26, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codablock codablock codablock approved these changes

@thephez thephez thephez approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
12.3
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @codablock @thephez