Make sure pwalletMain is not null whenever it's used in PS client #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladcow
reviewed
Jul 27, 2018
src/privatesend-client.cpp
Outdated
| @@ -689,9 +700,13 @@ bool CPrivateSendClient::DoAutomaticDenominating(CConnman& connman, bool fDryRun | |||
| { | |||
| if(fMasternodeMode) return false; // no client-side mixing on masternodes | |||
| if(!fEnablePrivateSend) return false; | |||
| if(!pwalletMain || pwalletMain->IsLocked(true)) return false; | |||
There was a problem hiding this comment.
Condition pwalletMain->IsLocked(true) is not checked in new code. Is it OK?
There was a problem hiding this comment.
Ooops. This is ok but it's from another fix. Will revert here.
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Apr 25, 2019
…shpay#2190) * Make sure pwalletMain is not null whenever it's used in PS client * partially revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes another crash when wallet is shutdown right after the start and makes code a bit safer in general :)