Skip to content

Fix ' warning: delete called on non-final 'PeerLogicValidation' that has virtual functions but non-virtual destructor' #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Duality-CDOO wants to merge 2 commits into from
Closed

Fix ' warning: delete called on non-final 'PeerLogicValidation' that has virtual functions but non-virtual destructor' #2363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbbece3
Fix ' warning: delete called on non-final 'PeerLogicValidation' that …
Duality-CDOO Oct 22, 2018
8e0e645
Add protected distructor for CValidationInterface
Duality-CDOO Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/net_processing.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ void RegisterNodeSignals(CNodeSignals& nodeSignals);
/** Unregister a network node */
void UnregisterNodeSignals(CNodeSignals& nodeSignals);

class PeerLogicValidation : public CValidationInterface {
class PeerLogicValidation final : public CValidationInterface {
private:
CConnman* connman;

Expand Down
1 change: 1 addition & 0 deletions src/validationinterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ void UnregisterAllValidationInterfaces();

class CValidationInterface {
protected:
~CValidationInterface() = default;
virtual void AcceptedBlockHeader(const CBlockIndex *pindexNew) {}
virtual void NotifyHeaderTip(const CBlockIndex *pindexNew, bool fInitialDownload) {}
virtual void UpdatedBlockTip(const CBlockIndex *pindexNew, const CBlockIndex *pindexFork, bool fInitialDownload) {}
Expand Down