-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Change chainlocks enforcing/notification flow #2762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
081a40caeb8f2d14f8e38a3820267fd86cf3d0b2 utACK LGTM
We should probably add ChainLocks ZMQ if we haven't so far
5f8c42b to
cd24474
Compare
|
Rebased. Changes without whitespaces https://github.com/dashpay/dash/pull/2762/files?w=1 |
PastaPastaPasta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the opinion is on stuff like this. Again we do it a lot in the code base, but I'm definitely not a fan
|
Hmm, this will conflict quite a bit with what I'm working on right now (what I mentioned on Slack, the rework of how |
Should enforce/notify when we have the block, not when we have only the header or trying to sign the tip (the later won't even work for non-masternodes). Also, fix few related (dead)locks.
|
@codablock I don't see why/how these two would conflict cause this one just fixes it in such a way that it would actually work on all nodes and for both fyi: rebased and force-pushed to trigger Travis build, no code changes. |
|
closing in fav of #2765 |
Should enforce/notify when we have the block, not when we have only the header or trying to sign the tip (the later won't even work for non-masternodes).
Also, fix few related (dead)locks.
NOTE: This includes #2759 atm, will rebase after it's merged. The actual changes are in 081a40c.