Skip to content

Conversation

@PastaPastaPasta
Copy link
Member

…ntation

b421e6d Update example bitcoin.conf (Alex Morcos)
7d4e950 Allow setting minrelaytxfee to 0 (Alex Morcos)
359e8a0 [cleanup] Remove coin age priority completely. (Alex Morcos)
f9b9371 [rpc] Remove priorityDelta from prioritisetransaction (Alex Morcos)
49be7e1 [rpc] Remove priority information from mempool RPC calls (Alex Morcos)
0315888 [test] Remove priority from tests (Alex Morcos)
f838005 No longer allow "free" transactions (Alex Morcos)
ad727f4 [rpc] sendrawtransaction no longer bypasses minRelayTxFee (Alex Morcos)
fe282ac [cleanup] Remove estimatePriority and estimateSmartPriority (Alex Morcos)
400b151 [debug] Change -printpriority option (Alex Morcos)
272b25a [mining] Remove -blockprioritysize. (Alex Morcos)
12839cd [rpc] Remove estimatepriority and estimatesmartpriority. (Alex Morcos)
ddf58c7 wallet: Remove sendfree (MarcoFalke)

Tree-SHA512: a9a4499405923ce794ef18f9e334dbbd59dfc73a3dc2df6f85cc9c62af6f353ec2eed9c2d5e58e904f918d0d7ab738f403dd4939d9bc2276136864fe63710782
Signed-off-by: Pasta Pasta@dash.org

@PastaPastaPasta
Copy link
Member Author

PastaPastaPasta commented Mar 13, 2019

This PR breaks since private-send code since PS uses priority to not have to add fees to mix txs.

…implementation

b421e6d Update example bitcoin.conf (Alex Morcos)
7d4e950 Allow setting minrelaytxfee to 0 (Alex Morcos)
359e8a0 [cleanup] Remove coin age priority completely. (Alex Morcos)
f9b9371 [rpc] Remove priorityDelta from prioritisetransaction (Alex Morcos)
49be7e1 [rpc] Remove priority information from mempool RPC calls (Alex Morcos)
0315888 [test] Remove priority from tests (Alex Morcos)
f838005 No longer allow "free" transactions (Alex Morcos)
ad727f4 [rpc] sendrawtransaction no longer bypasses minRelayTxFee (Alex Morcos)
fe282ac [cleanup] Remove estimatePriority and estimateSmartPriority (Alex Morcos)
400b151 [debug] Change -printpriority option (Alex Morcos)
272b25a [mining] Remove -blockprioritysize. (Alex Morcos)
12839cd [rpc] Remove estimatepriority and estimatesmartpriority. (Alex Morcos)
ddf58c7 wallet: Remove sendfree (MarcoFalke)

Tree-SHA512: a9a4499405923ce794ef18f9e334dbbd59dfc73a3dc2df6f85cc9c62af6f353ec2eed9c2d5e58e904f918d0d7ab738f403dd4939d9bc2276136864fe63710782
Signed-off-by: Pasta <Pasta@dash.org>

Fix backport and fix dash specific priority code
@PastaPastaPasta PastaPastaPasta marked this pull request as ready for review March 13, 2019 21:42
@PastaPastaPasta
Copy link
Member Author

tests passing locally, pls review

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 added this to the 14.0 milestone Mar 13, 2019
@UdjinM6 UdjinM6 mentioned this pull request Mar 13, 2019
@UdjinM6 UdjinM6 requested a review from codablock March 14, 2019 14:08
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍

@UdjinM6 UdjinM6 changed the title Merge #9602: Remove coin age priority and free transactions - impleme… Merge bitcoin#9602: Remove coin age priority and free transactions - impleme… Mar 14, 2019
@UdjinM6 UdjinM6 merged commit 6f90cf7 into dashpay:develop Mar 14, 2019
@PastaPastaPasta PastaPastaPasta deleted the 9602 branch March 14, 2019 15:25
@UdjinM6 UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Mar 14, 2019
thephez added a commit to thephez/dash-docs that referenced this pull request Aug 20, 2019
thephez added a commit to dash-docs/dash-docs that referenced this pull request Aug 22, 2019
* RPC - Add getmemoryinfo mode parameter

* RPC - Update RPC Table and quick-ref for getmemoryinfo

* RPC - Add disconnectnode nodeid parameter

* RPC - Update formatting of previous versions

* RPC - Add getmempoolinfo instantsendlocks param

* Correct RPC table getmemoryinfo entry

* Formatting - fix getmempoolinfo indentation

* RPC - getinfo add deprecations-warning

* RPC - estimatesmartfee add conservative param

* RPC - remove instantsendtoaddress references

* RPC - IS changes
 - Remove instantsend field from result of getmempoolentry and 
getrawmempool
 - Deprecated IS send params for multiple RPCs

* RPC - Remove deprecated starting/current priority fields
 Related to dashpay/dash#2768

* Add missing change to fix build error

* RPC Table and quick ref updates

* RPC - Add addrbind to getpeerinfo

* RPC - Add bogosize and disk_size to gettxoutsetinfo

* RPC - Add query_options to listunspent

* Typo fix in generate RPC

* RPC - Add abortrescan

* Formatting fix

* RPC - Add param to listsinceblock 
Also fix depth issue with full tx template and add abandoned field

* RPC - update 2nd param name in submitblock

* RPC - Add conf_target and estimate_mode to sendmany and sendtoaddress

* RPC - Add new uptime RPC

* RPC - Add new listwallets RPC

* RPC - Add new getchaintxstats RPC

* RPC - Update category list for debug

* RPC - Update getblockchaininfo statistics format

* RPC - Add uptime to table

* RPC - Add new logging RPC

* RPC - Add hex field to getblock

* Update rpc table
thephez added a commit to dash-docs/dash-docs that referenced this pull request Feb 19, 2020
* RPC - Add getmemoryinfo mode parameter

* RPC - Update RPC Table and quick-ref for getmemoryinfo

* RPC - Add disconnectnode nodeid parameter

* RPC - Update formatting of previous versions

* RPC - Add getmempoolinfo instantsendlocks param

* Correct RPC table getmemoryinfo entry

* Formatting - fix getmempoolinfo indentation

* RPC - getinfo add deprecations-warning

* RPC - estimatesmartfee add conservative param

* RPC - remove instantsendtoaddress references

* RPC - IS changes
 - Remove instantsend field from result of getmempoolentry and 
getrawmempool
 - Deprecated IS send params for multiple RPCs

* RPC - Remove deprecated starting/current priority fields
 Related to dashpay/dash#2768

* Add missing change to fix build error

* RPC Table and quick ref updates

* RPC - Add addrbind to getpeerinfo

* RPC - Add bogosize and disk_size to gettxoutsetinfo

* RPC - Add query_options to listunspent

* Typo fix in generate RPC

* RPC - Add abortrescan

* Formatting fix

* RPC - Add param to listsinceblock 
Also fix depth issue with full tx template and add abandoned field

* RPC - update 2nd param name in submitblock

* RPC - Add conf_target and estimate_mode to sendmany and sendtoaddress

* RPC - Add new uptime RPC

* RPC - Add new listwallets RPC

* RPC - Add new getchaintxstats RPC

* RPC - Update category list for debug

* RPC - Update getblockchaininfo statistics format

* RPC - Add uptime to table

* RPC - Add new logging RPC

* RPC - Add hex field to getblock

* Update rpc table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants