Skip to content

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented May 2, 2019

No description provided.

@nmarley
Copy link

nmarley commented May 6, 2019

Just curious -- any specific reason consumeCollateral is a lambda instead of a regular function? Or just simpler since it's only called in CPrivateSendServer::ProcessMessage scope?

@UdjinM6
Copy link
Author

UdjinM6 commented May 6, 2019

@nmarley That's a good point, we can reuse it in a couple of other places actually. Fixed.

@UdjinM6 UdjinM6 added this to the 14.1 milestone May 10, 2019
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6
Copy link
Author

UdjinM6 commented May 22, 2019

Rebased to fix log category after #2918

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit c08e761 into dashpay:develop May 23, 2019
@UdjinM6 UdjinM6 deleted the tightenpsrules branch November 26, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants