Refactor validation signals for ChainLocks, InstantSend and PrivateSend to get rid of SyncTransaction #2943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDSNotificationInterface::BlockDisconnected still calls SyncTransaction with pprev to keep compatibility.
This commit moves all logic of SyncTransaction into ProcessNewTransaction and then calls it from TransactionAddedToMempool and BlockConnected. This won't compile/work at first, but the next commits will fix this.
ProcessNewTransaction is now only called with pindex != nullptr when a block is connected but never when it is disconnected, so there is no need to check for posInBlock anymore (we don't even have it now).
Also add code to remove entries in blockTxs when BlockDisconnected is called.
…lockConnected This removes the need for SyncTransaction
Instead of relying on CDSNotificationInterface running compatibility code. This also removes locking of cs_main, as this seemed to be not needed.
UdjinM6
changed the title
UdjinM6
reviewed
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2931 has removed the SyncTransaction signal but used some compatiblity code for CDSNotificationInterface so that things still worked. This PR removes the compatibility code and refactors/reimplements signal handling in a way that it doesn't need SyncTransaction anymore.