A couple of fixes for CActiveMasternodeManager::Init() #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Init This is needed after backporting 11363 in 3305
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 25, 2021
* Create socket manually when self-checking masternode connectivity in Init This is needed after backporting 11363 in 3305 * Check socket connectivity on regtest too * Fix log output
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 17, 2022
* Create socket manually when self-checking masternode connectivity in Init This is needed after backporting 11363 in 3305 * Check socket connectivity on regtest too * Fix log output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Socket connectivity check is broken in
developdue to changes brought by backporting 11363 via #3305 - have to create new socket manually now.Not sure why we skip this part on regtest, I didn't notice any issues with tests after re-enabling it (diff ignoring changes in whitespaces: 669b21b?w=1, Travis: https://travis-ci.org/UdjinM6/dash/builds/647121898).
Also, fixing incorrect log output while at it.