Call FlushBackgroundCallbacks before resetting CConnman #3378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
added a commit
to UdjinM6/dash
that referenced
this pull request
Jan 22, 2021
This is needed to be able to process SetBestChain callback generated by the first FlushStateToDisk call in PrepareShutdown Partially reverts dashpay#3378
PastaPastaPasta
pushed a commit
that referenced
this pull request
Jan 25, 2021
This is needed to be able to process SetBestChain callback generated by the first FlushStateToDisk call in PrepareShutdown Partially reverts #3378
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Feb 22, 2022
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Apr 1, 2022
This is needed to be able to process SetBestChain callback generated by the first FlushStateToDisk call in PrepareShutdown Partially reverts dashpay#3378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes crashes on shutdown due to flushed callbacks still accessing g_connman and friends. This should fix failing tests like in https://gitlab.com/dashpay/dash/-/jobs/485301095