Fix deadlocks #3456
Merged
Fix deadlocks #3456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes deadlocks introduced in 78d303c/dashpay#3361
POTENTIAL DEADLOCK DETECTED Previous lock order was: pnode->cs_sendProcessing net.cpp:2724 cs_main net_processing.cpp:3867 (TRY) (1) pto->cs_inventory net_processing.cpp:4106 (2) cs txmempool.cpp:1137 Current lock order is: cs_main wallet/rpcwallet.cpp:468 (2) mempool.cs wallet/rpcwallet.cpp:468 pwallet->cs_wallet wallet/rpcwallet.cpp:469 cs_main wallet/wallet.cpp:4045 (2) mempool.cs wallet/wallet.cpp:4045 cs_wallet wallet/wallet.cpp:4046 cs_vNodes net.cpp:3464 (1) cs_inventory ./net.h:1056
This was referenced May 11, 2020
Closed
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Feb 14, 2022
* Lock mempool before locking cs_wallet This fixes deadlocks introduced in 78d303c/dashpay#3361 * Fix mempool.cs vs cs_inventory potential deadlock POTENTIAL DEADLOCK DETECTED Previous lock order was: pnode->cs_sendProcessing net.cpp:2724 cs_main net_processing.cpp:3867 (TRY) (1) pto->cs_inventory net_processing.cpp:4106 (2) cs txmempool.cpp:1137 Current lock order is: cs_main wallet/rpcwallet.cpp:468 (2) mempool.cs wallet/rpcwallet.cpp:468 pwallet->cs_wallet wallet/rpcwallet.cpp:469 cs_main wallet/wallet.cpp:4045 (2) mempool.cs wallet/wallet.cpp:4045 cs_wallet wallet/wallet.cpp:4046 cs_vNodes net.cpp:3464 (1) cs_inventory ./net.h:1056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My nodes running on
developkeep getting stuck randomly every day or two. I believe it's because of deadlocks introduced in 78d303c. Had to disable scheduler in validation interface to find them 6047b18a84 https://travis-ci.org/github/UdjinM6/dash/builds/679522457. With these patches applied on top of that branch tests pass again (no deadlocks).