Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #17249: rpc: Add missing deque include to fix build #3815

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Backport #17249: rpc: Add missing deque include to fix build #3815

merged 1 commit into from
Nov 17, 2020

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Nov 14, 2020

This fixes build issues on Fedora 33 (https://pastebin.com/6m7X4mvM) reported by t0dd on Discord.

Original pull request description:

Regressed by boostorg/filesystem@9a14c37d6f95. See error log.

httpserver.cpp:74:10: error: no template named 'deque' in namespace 'std'
    std::deque<std::unique_ptr<WorkItem>> queue;
    ~~~~~^

@laanwj @UdjinM6
Merge bitcoin#17249: rpc: Add missing deque include to fix build
565d326 
a592913 http: add missing header bootlegged by boost < 1.72 (Jan Beich)

Pull request description:

  Regressed by boostorg/filesystem@9a14c37d6f95. See [error log](https://github.com/bitcoin/bitcoin/files/3772177/bitcoin-0.18.1.log).

  ```c++
  httpserver.cpp:74:10: error: no template named 'deque' in namespace 'std'
      std::deque<std::unique_ptr<WorkItem>> queue;
      ~~~~~^
  ```

ACKs for top commit:
  laanwj:
    ACK a592913

Tree-SHA512: fb0aee6a698c7aaa6a73baad7adc4f891be573af0d3cf6f4f59bc825afe5c0bc439c668077ff1990a6135522a0533a1a867430eebad28f0ade93fd79a95e179b
@UdjinM6 UdjinM6 added this to the 17 milestone Nov 14, 2020
xdustinface
xdustinface approved these changes Nov 14, 2020
View reviewed changes
Copy link

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PastaPastaPasta
PastaPastaPasta approved these changes Nov 15, 2020
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit fa4d993 into dashpay:develop Nov 17, 2020
@UdjinM6 UdjinM6 deleted the fix_boost_1.72_build branch November 26, 2020 13:26
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Apr 18, 2022
@UdjinM6 @laanwj @gades
Backport bitcoin#17249: rpc: Add missing deque include to fix build (d…
28e12b2 
…ashpay#3815)

a592913 http: add missing header bootlegged by boost < 1.72 (Jan Beich)

Pull request description:

  Regressed by boostorg/filesystem@9a14c37d6f95. See [error log](https://github.com/bitcoin/bitcoin/files/3772177/bitcoin-0.18.1.log).

  ```c++
  httpserver.cpp:74:10: error: no template named 'deque' in namespace 'std'
      std::deque<std::unique_ptr<WorkItem>> queue;
      ~~~~~^
  ```

ACKs for top commit:
  laanwj:
    ACK a592913

Tree-SHA512: fb0aee6a698c7aaa6a73baad7adc4f891be573af0d3cf6f4f59bc825afe5c0bc439c668077ff1990a6135522a0533a1a867430eebad28f0ade93fd79a95e179b

Co-authored-by: Wladimir J. van der Laan <laanwj@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdustinface xdustinface xdustinface approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17
Development

Successfully merging this pull request may close these issues.
4 participants
@UdjinM6 @PastaPastaPasta @xdustinface @laanwj