Skip to content

Reconsider best invalid chain tip outside of ThreadImport to avoid exposing rpc too early #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
UdjinM6 wants to merge 1 commit into from
Closed

Reconsider best invalid chain tip outside of ThreadImport to avoid exposing rpc too early #3966

UdjinM6 wants to merge 1 commit into from

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jan 23, 2021 •
edited
Loading

A followup for #3926

@UdjinM6 UdjinM6 added this to the 17 milestone Jan 23, 2021
@UdjinM6 UdjinM6 marked this pull request as ready for review January 23, 2021 15:01
@UdjinM6 UdjinM6 mentioned this pull request Jan 23, 2021
Merged
@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Jan 25, 2021

Can you explain a bit more what's going on here?

@UdjinM6
Copy link
Author

UdjinM6 commented Jan 25, 2021

For huge reorgs (like in feature_pruning.py for example) ACB takes a lot of time and rpc is exposed before ThreadImport/ACB had a chance to finish its job. I thought this was the reason for some issues in tests due to fork recovery stuff... but I can no longer reproduce them it seems 🙈 Closing.

@UdjinM6 UdjinM6 closed this Jan 25, 2021
@UdjinM6 UdjinM6 removed this from the 17 milestone Jan 25, 2021
@UdjinM6 UdjinM6 deleted the reconsider_early branch July 1, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@UdjinM6 @PastaPastaPasta