instantsend: Ignore IS while reindexing/loading blocks from file, bail out early when IS is off #3985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PastaPastaPasta
requested changes
Feb 17, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
NACK de8192e
We really only call these functions from places where we already check if IS is enabled or not. Additionally, nothing about IS being disabled really prohibits these functions from doing their job. If anything, these checks just add additional overhead and should probably be avoided.
…ByInput and GetInstantSendLockByHash
Author
|
My idea was to kind of guard the access to db with these checks (the overhead is tiny compared to db reads/writes I think) but it does look like we have it all covered in other places atm, even though it takes some jumping back and forth through the code to figure it out. Dropped most of them and only kept the one in |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 13, 2022
…l out early when IS is off (dashpay#3985) * instantsend: Bail out early on disabled IS in more places * instantsend: Disable InstantSend while reindexing and importing blocks * Drop extra checks in GetInstantSendLockHashByTxid, GetInstantSendLockByInput and GetInstantSendLockByHash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits.
Extracted from #3970,
based on #3984 atm