Skip to content

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Mar 26, 2021

Fix/update masternode count, deprecate masternode current and masternode winner.

@UdjinM6 UdjinM6 added this to the 17 milestone Mar 26, 2021
@UdjinM6 UdjinM6 changed the title rpc: Adjust masternode rpcs rpc: Adjust some masternode rpcs Mar 26, 2021
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@xdustinface xdustinface added the RPC Some notable changes to RPC params/behaviour/descriptions label Mar 26, 2021
@xdustinface xdustinface merged commit 9420314 into dashpay:develop Mar 26, 2021
@UdjinM6 UdjinM6 deleted the rpc_masternode branch July 1, 2021 21:59
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 22, 2022
* rpc: Deprecate `masternode current` and `masternode winner`

* rpc: Drop deprecated `mode` param in `masternode count`
PastaPastaPasta added a commit that referenced this pull request Feb 16, 2025
…rnode winner` and `getpoolinfo`

7c81d53 chore: drop deprecated CoinJoin RPC `getpoolinfo` (Kittywhiskers Van Gogh)
7cdd4f3 chore: drop deprecated `masternode` RPC verbs `winner` and `current` (Kittywhiskers Van Gogh)

Pull request description:

  ## Additional Information

  * `masternode current`, `masternode winner` were deprecated in [dash#4060](#4060), which was included in Dash Core v0.17
  * `getpoolinfo` was deprecated in [dash#3140](#3140), which was included in Dash Core v0.15.

  ## Breaking Changes

  Deprecated RPCs will no longer be available.

  ## Checklist

  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**
  - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)**
  - [x] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK 7c81d53
  knst:
    utACK 7c81d53

Tree-SHA512: 3ee21be2114ebeb139694f77fe6dfc30ee6f9404db6b0aa328a8179a9091b189bf6494e5c54b637aa1ab4f06fa7c3edc6bba26eab2a97b5f987fcd66952040b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants