Qt: Adds Governance tab #4351

5tefan · 2021-08-19T08:20:27Z

Towards #4337, implementing DMT-like Governance Functionality.

5tefan · 2021-08-20T07:14:17Z

Views of the new functionality:

Questions:

What columns to display? Probably include vote counts/ratio. Is showing url necessary with right click to open url exists?
Looking a bit simper than Masternode list, not subscribing to updates from core: just periodically refresh, or include a refresh button?
Show proposals only?

UdjinM6 · 2021-08-20T18:58:13Z

Nice! 👍

Questions:

What columns to display? Probably include vote counts/ratio. Is showing url necessary with right click to open url exists?

Would be nice to have "Voting status" implemented in a similar way it's done in DMT imo. Also, cycles (e.g. current/total) and total amount might be useful in this list. URL, yes/no/abstain counts etc. can be shown in a separate panel like it's done in DMT (i.e. you select a proposal and this populates "Details" panel below).

Looking a bit simper than Masternode list, not subscribing to updates from core: just periodically refresh, or include a refresh button?

The list is small here (10s comparing to 1000s in mn list), periodic updates should be ok I think (assuming they won't cause issues with "Details" panel I mentioned above).

Show proposals only?

Yeah, I think it would be better to start with proposals first. We can get back to triggers later when we polish proposals list(/vote?) functionality.

github-actions · 2021-08-24T16:16:46Z

This pull request has conflicts, please rebase.

src/qt/governancelist.cpp

src/qt/optionsdialog.cpp

github-actions · 2021-10-01T19:21:39Z

This pull request has conflicts, please rebase.

WIP: basically ready to be filled out, most of the infra in place now.

Governance table now contains real values for current columns. Display columns may potentially change. - want url in table if right click option opens url? - What set of cols wanted? Show yes/no votes? - Decide refresh functionality. - Do we even want filter func? (checkbox show: proposal, trigger, active coming)

Towards DMT like Governance page, now shows voting status, but needs to look at super blocks to determine if proposal period has passed and show final funded or unfunded for past proposals.

Refactors the QT Governance tab to use a Model-View architecture. The list of Proposals is stored in a QAbstractItemModel, and a QTableView is used to display. This makes a much cleaner separation of concerns in the implementation. Also, can now use the QSortFilterProxyModel to get responsive filtering. Less internal state inside the GovernanceList, critical sections removed. - Needs update loop implemented. - Needs Proposal detail widget implemented.

Periodically update list of governance related proposals.

- Adds LOCK(cs_main) for call to pGovObj->IsValidLocally. - retab, removes trailing whitespace in governancelist.{cpp,h}

PastaPastaPasta · 2021-10-13T16:25:23Z

Please see formatting changes https://github.com/dashpay/dash/pull/4351/checks?check_run_id=3878279015

…ll name

UdjinM6

pls see https://github.com/UdjinM6/dash/commits/pr4351 for some suggestions

5tefan · 2021-10-26T04:07:06Z

@UdjinM6, sorry I think your pr4351 branch may have been deleted?

UdjinM6 · 2021-10-26T09:01:41Z

oops, sorry, should be available again

5tefan · 2021-10-27T04:12:35Z

No worries, thanks! I like those changes. Just caught one extra place that should refer to the full column name.

UdjinM6 · 2021-10-28T11:22:21Z

two more fixes, pls see 20e51e2 and 7e40bed

UdjinM6

LGTM

ACK

PastaPastaPasta

ACK for squash merge

PastaPastaPasta · 2021-10-30T01:14:21Z

Things for future changes:
Add: Yes count, No count, Abstain Count, Absolute Yes coin, url
Remove: Hash
Replace Start, End dates with computed "Payments Remaining"

We should consider adding a pop-up warning before opening the proposal URL

* Qt: Adds settings option to showGovernanceTab * Qt: Adds not-yet-functional Governance tab to UI * library: adds hook into governance rom node interface * Qt: WIP: puts CGovernanceObject hashes on Governance tab WIP: basically ready to be filled out, most of the infra in place now. * Qt: Populates Governance table values Governance table now contains real values for current columns. Display columns may potentially change. - want url in table if right click option opens url? - What set of cols wanted? Show yes/no votes? - Decide refresh functionality. - Do we even want filter func? (checkbox show: proposal, trigger, active coming) * qt: Shows Voting Status on Governance page Towards DMT like Governance page, now shows voting status, but needs to look at super blocks to determine if proposal period has passed and show final funded or unfunded for past proposals. * Qt: refactor governance tab to use Model-View arch Refactors the QT Governance tab to use a Model-View architecture. The list of Proposals is stored in a QAbstractItemModel, and a QTableView is used to display. This makes a much cleaner separation of concerns in the implementation. Also, can now use the QSortFilterProxyModel to get responsive filtering. Less internal state inside the GovernanceList, critical sections removed. - Needs update loop implemented. - Needs Proposal detail widget implemented. * qt: adds periodic update to gov proposal list Periodically update list of governance related proposals. * qt: populates governancelist voting status column * qt: governancelist Porposal shows extra info on doubleClick * qt: governancelist: reorder .cpp impl to match .h * qt: governancelist: fixup based on CI - Adds LOCK(cs_main) for call to pGovObj->IsValidLocally. - retab, removes trailing whitespace in governancelist.{cpp,h} * qt: clang-format for governancelist * Fixes - drop unused include - use proper univalue "get_" functions - shorter/translatable statuses - shorter dates - add missing css styles * qt: addresses governancelist code review items * qt: use enum to name columns of governancelist * fix: clear context menu before adding new items * fix: skip potential nullptr proposals * improve: show proposal url in context menu * refactor: tweak enum name, make sure it's int starting from 0, use full name * fix: column count * improve: make it sortable, sort by start_date by default * qt: use full col name in voting status col change signal emit * better sorting * use mapToSource to fix data fetching Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

github-actions bot added the needs rebase label Aug 24, 2021

5tefan force-pushed the iss4337 branch from 342e965 to a13e6b1 Compare August 25, 2021 05:30

github-actions bot removed the needs rebase label Aug 25, 2021

UdjinM6 requested changes Aug 25, 2021

View reviewed changes

src/qt/governancelist.cpp Outdated Show resolved Hide resolved

src/qt/optionsdialog.cpp Outdated Show resolved Hide resolved

github-actions bot added the needs rebase label Oct 1, 2021

5tefan force-pushed the iss4337 branch from a13e6b1 to c7c8df4 Compare October 12, 2021 06:48

5tefan added 2 commits October 12, 2021 00:49

Qt: Adds settings option to showGovernanceTab

1f080db

Qt: Adds not-yet-functional Governance tab to UI

c761dbb

5tefan force-pushed the iss4337 branch from c7c8df4 to be6287a Compare October 12, 2021 06:51

github-actions bot removed the needs rebase label Oct 12, 2021

5tefan force-pushed the iss4337 branch from be6287a to 752f0f9 Compare October 13, 2021 03:19

5tefan added 9 commits October 12, 2021 21:23

library: adds hook into governance rom node interface

02c7871

Qt: WIP: puts CGovernanceObject hashes on Governance tab

89398e9

WIP: basically ready to be filled out, most of the infra in place now.

qt: Shows Voting Status on Governance page

a699583

Towards DMT like Governance page, now shows voting status, but needs to look at super blocks to determine if proposal period has passed and show final funded or unfunded for past proposals.

qt: adds periodic update to gov proposal list

64de966

Periodically update list of governance related proposals.

qt: populates governancelist voting status column

a6437d3

qt: governancelist Porposal shows extra info on doubleClick

a62e987

qt: governancelist: reorder .cpp impl to match .h

75c05d0

5tefan force-pushed the iss4337 branch from 752f0f9 to 75c05d0 Compare October 13, 2021 03:24

qt: governancelist: fixup based on CI

f8170af

- Adds LOCK(cs_main) for call to pGovObj->IsValidLocally. - retab, removes trailing whitespace in governancelist.{cpp,h}

5tefan force-pushed the iss4337 branch from 43ffffc to f8170af Compare October 13, 2021 03:58

5tefan marked this pull request as ready for review October 13, 2021 04:46

PastaPastaPasta requested a review from UdjinM6 October 13, 2021 16:24

UdjinM6 added 6 commits October 19, 2021 22:29

fix: clear context menu before adding new items

7ad14bd

fix: skip potential nullptr proposals

c162798

improve: show proposal url in context menu

92b5689

refactor: tweak enum name, make sure it's int starting from 0, use fu…

3a275b6

…ll name

fix: column count

7e6f070

improve: make it sortable, sort by start_date by default

7a3fe32

UdjinM6 requested changes Oct 19, 2021

View reviewed changes

qt: use full col name in voting status col change signal emit

88da039

5tefan requested review from PastaPastaPasta and UdjinM6 October 27, 2021 04:14

UdjinM6 added 2 commits October 28, 2021 04:10

better sorting

7e40bed

use mapToSource to fix data fetching

20e51e2

UdjinM6 added this to the 18 milestone Oct 29, 2021

UdjinM6 approved these changes Oct 29, 2021

View reviewed changes

UdjinM6 mentioned this pull request Oct 29, 2021

Qt: Add DMT-like Governance Functionality refs #4337 - #4358

Closed

PastaPastaPasta approved these changes Oct 30, 2021

View reviewed changes

PastaPastaPasta merged commit f0d49e4 into dashpay:develop Oct 30, 2021

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Oct 30, 2021

minor refactoring after dashpay#4351

f1ab97b

UdjinM6 pushed a commit that referenced this pull request Nov 1, 2021

minor refactoring after #4351 (#4556)

ea4bd71

pravblockc pushed a commit to pravblockc/dash that referenced this pull request Nov 18, 2021

minor refactoring after dashpay#4351 (dashpay#4556)

c9b5c83

daharkan mentioned this pull request Dec 19, 2021

implemented changes suggested PR#4351 #4629

Open

kxcd mentioned this pull request Feb 14, 2022

BUG: Change date format in Governance tab grid to display as yyyy-mm-dd #4688

Open

gades pushed a commit to cosanta/cosanta-core that referenced this pull request May 8, 2022

minor refactoring after dashpay#4351 (dashpay#4556)

9eb38df

Qt: Adds Governance tab #4351

Qt: Adds Governance tab #4351

Uh oh!

Conversation

5tefan commented Aug 19, 2021

Uh oh!

5tefan commented Aug 20, 2021

Uh oh!

UdjinM6 commented Aug 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 24, 2021

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 1, 2021

Uh oh!

PastaPastaPasta commented Oct 13, 2021

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

5tefan commented Oct 26, 2021

Uh oh!

UdjinM6 commented Oct 26, 2021

Uh oh!

5tefan commented Oct 27, 2021

Uh oh!

UdjinM6 commented Oct 28, 2021

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta commented Oct 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

UdjinM6 commented Aug 20, 2021 •

edited

Loading