merge bitcoin#14700...#16854: backports #4606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
requested changes
Dec 7, 2021
PastaPastaPasta
previously approved these changes
Dec 11, 2021
kwvg
force-pushed
the
portsportsports
branch
from
15d035d to
e580381
Compare
UdjinM6
changed the title
PastaPastaPasta
requested changes
Dec 12, 2021
kwvg
force-pushed
the
portsportsports
branch
2 times, most recently
from
11c5fc5 to
d81793f
Compare
UdjinM6
reviewed
Dec 17, 2021
src/rpc/rawtransaction.cpp
Outdated
Comment on lines
+1449
to
+1445
There was a problem hiding this comment.
13932: hmmm... doesn't this mean that in our case utxoupdatepsbt simply does nothing all the time?
Collaborator
Author
There was a problem hiding this comment.
Yes, it exists only to exist but I presume that its absence may be an unexpected API deviation so it was added in despite practically being a NOP.
|
This pull request has conflicts, please rebase. |
kwvg
force-pushed
the
portsportsports
branch
from
d81793f to
45c8ee6
Compare
UdjinM6
reviewed
Dec 19, 2021
kwvg
force-pushed
the
portsportsports
branch
from
45c8ee6 to
c29d0c5
Compare
PastaPastaPasta
approved these changes
Dec 21, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
UdjinM6
added a commit
to UdjinM6/dash
that referenced
this pull request
Dec 30, 2021
merged via dashpay#4606
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 16, 2023
merged via dashpay#4606
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
merged via dashpay#4606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.