Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #16226 #4640

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Merge #16226 #4640

merged 1 commit into from
Apr 3, 2022

Commits on Apr 1, 2022

  1. Merge bitcoin#16226: Move ismine to the wallet module

    e61de63 Change ismine to take a CWallet instead of CKeyStore (Andrew Chow)
    7c611e2 Move ismine to wallet module (Andrew Chow)
    
    Pull request description:
    
      `IsMine` isn't used outside of the wallet except for the tests. It also doesn't make sense to be outside of the wallet. This PR moves `IsMine` into the wallet module and for it to take a `CWallet` instead of `CKeyStore`. The test that used `IsMine` is also moved to the wallet tests.
    
      This is first [prerequisites](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Wallet-Class-Structure-Changes#ismine) for the wallet structure changes.
    
    ACKs for commit e61de6:
      MarcoFalke:
        re-ACK e61de63 (only change is rebase with git auto-merge)
      meshcollider:
        Very light code review ACK bitcoin@e61de63
    
    Tree-SHA512: 1cb4ad12652aef7922ab7460c6d413e8b9d1855dca78c0a286ae49d5c0765bc7996c55f262c742001d434eb9bd4215dc2cc7aae1b371ee1a82d46b32c17e6341
    meshcollider authored and vijaydasmp committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    a4b5a6a View commit details
    Browse the repository at this point in the history