Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: use pull_request_target instead of pull_request, use custom fork #4647

Merged
merged 2 commits into from
Dec 30, 2021

Conversation

PastaPastaPasta
Copy link
Member

Should fix not being able to comment

Signed-off-by: Pasta <pasta@dashboost.org>
@UdjinM6
Copy link

UdjinM6 commented Dec 30, 2021

hmmm... Are you sure?

    if (context.eventName !== 'pull_request') {
      throw new Error(`This action only work with pull_request event not  ${context.eventName}`);
    }

https://github.com/outsideris/potential-conflicts-checker-action/blob/fdecbd447c6399f91d425b8adad1256775727d9d/index.js#L13-L15

EDIT: and official Usage section also mentions pull_request, not pull_request_target

Signed-off-by: Pasta <pasta@dashboost.org>
@PastaPastaPasta
Copy link
Member Author

Yeah, you're right.. Need to update the action (there's no reason imo to not allow pull_request_target) see https://github.com/PastaPastaPasta/potential-conflicts-checker-action tag 0.1.1

also see PastaPastaPasta#26 and PastaPastaPasta#25

rebased on using my custom action, uses pull_request_target, and everything is happy

@PastaPastaPasta PastaPastaPasta changed the title actions: use pull_request_target instead of pull_request actions: use pull_request_target instead of pull_request, use custom fork Dec 30, 2021
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
utACK

@UdjinM6 UdjinM6 merged commit 1c925ed into dashpay:develop Dec 30, 2021
@PastaPastaPasta PastaPastaPasta deleted the fix-action branch December 30, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants