Fix "cs_main not held" in SyncObjects #4694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PastaPastaPasta
requested changes
Feb 22, 2022
src/governance/governance.cpp
Outdated
Comment on lines
675
to
679
| bool fAllowScript{false}; | ||
| { | ||
| LOCK(cs_main); | ||
| fAllowScript = (VersionBitsTipState(Params().GetConsensus(), Consensus::DEPLOYMENT_GOV_FEE) == ThresholdState::ACTIVE); | ||
| } |
Member
There was a problem hiding this comment.
please use = WITH_LOCK(...
PastaPastaPasta
approved these changes
Feb 23, 2022
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 13, 2023
* Fix "cs_main not held" in SyncObjects * use WITH_LOCK
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
* Fix "cs_main not held" in SyncObjects * use WITH_LOCK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Assertion failed: lock cs_main not held in validation.cpp:5257; locks held: 'cs' in governance/governance.cpp:675Followup to #4672
kudos @MrDefacto