Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/build: Kubuntu 22.04 build fix #4843

Merged
merged 3 commits into from
May 29, 2022

Conversation

knst
Copy link
Collaborator

@knst knst commented May 20, 2022

knst and others added 2 commits May 20, 2022 00:45
It adds a patch with missing include <limits> in qtbase/src/tools/moc/generator.cpp
…ementation

5b559dc Swap out hashlib.ripemd160 for own implementation (Pieter Wuille)
ad3e9e1 Add pure Python RIPEMD-160 (Pieter Wuille)

Pull request description:

  Closes bitcoin#23710.

ACKs for top commit:
  jamesob:
    ACK bitcoin@5b559dc, pending CI

Tree-SHA512: dcd4ea2027eac572f7ab0da434b081b9a5d6b78675e559258a446b4d254b29d93c4d2cc12da4a28303543d6d99f5f2246fde4052e84af81d18e04399b137b39e
@knst knst closed this May 20, 2022
@knst knst reopened this May 20, 2022
@knst knst changed the base branch from master to develop May 20, 2022 17:31
@PastaPastaPasta PastaPastaPasta modified the milestones: 18.1, 18 May 20, 2022
UdjinM6
UdjinM6 previously approved these changes May 22, 2022
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 dismissed their stale review May 23, 2022 17:43

waiting for byacc->bison update in doc

@knst knst force-pushed the kubuntu-22.04-fix branch from 71cf958 to a11e334 Compare May 24, 2022 08:08
@knst knst force-pushed the kubuntu-22.04-fix branch from a11e334 to 881438b Compare May 24, 2022 08:08
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK

@UdjinM6 UdjinM6 requested a review from PastaPastaPasta May 27, 2022 19:52
@PastaPastaPasta PastaPastaPasta changed the title Kubuntu 22.04 build fix docs: Kubuntu 22.04 build fix May 29, 2022
@PastaPastaPasta PastaPastaPasta changed the title docs: Kubuntu 22.04 build fix docs/build: Kubuntu 22.04 build fix May 29, 2022
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit e4dbd22 into dashpay:develop May 29, 2022
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request May 30, 2022
* Fix build of qtbase in contrib for Gcc 11.x

It adds a patch with missing include <limits> in qtbase/src/tools/moc/generator.cpp

* Merge bitcoin#23716: test: replace hashlib.ripemd160 with an own implementation

5b559dc Swap out hashlib.ripemd160 for own implementation (Pieter Wuille)
ad3e9e1 Add pure Python RIPEMD-160 (Pieter Wuille)

Pull request description:

  Closes bitcoin#23710.

ACKs for top commit:
  jamesob:
    ACK bitcoin@5b559dc, pending CI

Tree-SHA512: dcd4ea2027eac572f7ab0da434b081b9a5d6b78675e559258a446b4d254b29d93c4d2cc12da4a28303543d6d99f5f2246fde4052e84af81d18e04399b137b39e

* Updates doc for Unix build: added missing dependency bison

Co-authored-by: MarcoFalke <falke.marco@gmail.com>
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request May 30, 2022
* Fix build of qtbase in contrib for Gcc 11.x

It adds a patch with missing include <limits> in qtbase/src/tools/moc/generator.cpp

* Merge bitcoin#23716: test: replace hashlib.ripemd160 with an own implementation

5b559dc Swap out hashlib.ripemd160 for own implementation (Pieter Wuille)
ad3e9e1 Add pure Python RIPEMD-160 (Pieter Wuille)

Pull request description:

  Closes bitcoin#23710.

ACKs for top commit:
  jamesob:
    ACK bitcoin@5b559dc, pending CI

Tree-SHA512: dcd4ea2027eac572f7ab0da434b081b9a5d6b78675e559258a446b4d254b29d93c4d2cc12da4a28303543d6d99f5f2246fde4052e84af81d18e04399b137b39e

* Updates doc for Unix build: added missing dependency bison

Co-authored-by: MarcoFalke <falke.marco@gmail.com>
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Nov 5, 2023
* Fix build of qtbase in contrib for Gcc 11.x

It adds a patch with missing include <limits> in qtbase/src/tools/moc/generator.cpp

* Merge bitcoin#23716: test: replace hashlib.ripemd160 with an own implementation

5b559dc Swap out hashlib.ripemd160 for own implementation (Pieter Wuille)
ad3e9e1 Add pure Python RIPEMD-160 (Pieter Wuille)

Pull request description:

  Closes bitcoin#23710.

ACKs for top commit:
  jamesob:
    ACK bitcoin@5b559dc, pending CI

Tree-SHA512: dcd4ea2027eac572f7ab0da434b081b9a5d6b78675e559258a446b4d254b29d93c4d2cc12da4a28303543d6d99f5f2246fde4052e84af81d18e04399b137b39e

* Updates doc for Unix build: added missing dependency bison

Co-authored-by: MarcoFalke <falke.marco@gmail.com>
gades pushed a commit to piratecash/pirate that referenced this pull request Dec 9, 2023
* Fix build of qtbase in contrib for Gcc 11.x

It adds a patch with missing include <limits> in qtbase/src/tools/moc/generator.cpp

* Merge bitcoin#23716: test: replace hashlib.ripemd160 with an own implementation

5b559dc Swap out hashlib.ripemd160 for own implementation (Pieter Wuille)
ad3e9e1 Add pure Python RIPEMD-160 (Pieter Wuille)

Pull request description:

  Closes bitcoin#23710.

ACKs for top commit:
  jamesob:
    ACK bitcoin@5b559dc, pending CI

Tree-SHA512: dcd4ea2027eac572f7ab0da434b081b9a5d6b78675e559258a446b4d254b29d93c4d2cc12da4a28303543d6d99f5f2246fde4052e84af81d18e04399b137b39e

* Updates doc for Unix build: added missing dependency bison

Co-authored-by: MarcoFalke <falke.marco@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants