-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/build: Kubuntu 22.04 build fix #4843
Conversation
It adds a patch with missing include <limits> in qtbase/src/tools/moc/generator.cpp
…ementation 5b559dc Swap out hashlib.ripemd160 for own implementation (Pieter Wuille) ad3e9e1 Add pure Python RIPEMD-160 (Pieter Wuille) Pull request description: Closes bitcoin#23710. ACKs for top commit: jamesob: ACK bitcoin@5b559dc, pending CI Tree-SHA512: dcd4ea2027eac572f7ab0da434b081b9a5d6b78675e559258a446b4d254b29d93c4d2cc12da4a28303543d6d99f5f2246fde4052e84af81d18e04399b137b39e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK for squash merge
* Fix build of qtbase in contrib for Gcc 11.x It adds a patch with missing include <limits> in qtbase/src/tools/moc/generator.cpp * Merge bitcoin#23716: test: replace hashlib.ripemd160 with an own implementation 5b559dc Swap out hashlib.ripemd160 for own implementation (Pieter Wuille) ad3e9e1 Add pure Python RIPEMD-160 (Pieter Wuille) Pull request description: Closes bitcoin#23710. ACKs for top commit: jamesob: ACK bitcoin@5b559dc, pending CI Tree-SHA512: dcd4ea2027eac572f7ab0da434b081b9a5d6b78675e559258a446b4d254b29d93c4d2cc12da4a28303543d6d99f5f2246fde4052e84af81d18e04399b137b39e * Updates doc for Unix build: added missing dependency bison Co-authored-by: MarcoFalke <falke.marco@gmail.com>
* Fix build of qtbase in contrib for Gcc 11.x It adds a patch with missing include <limits> in qtbase/src/tools/moc/generator.cpp * Merge bitcoin#23716: test: replace hashlib.ripemd160 with an own implementation 5b559dc Swap out hashlib.ripemd160 for own implementation (Pieter Wuille) ad3e9e1 Add pure Python RIPEMD-160 (Pieter Wuille) Pull request description: Closes bitcoin#23710. ACKs for top commit: jamesob: ACK bitcoin@5b559dc, pending CI Tree-SHA512: dcd4ea2027eac572f7ab0da434b081b9a5d6b78675e559258a446b4d254b29d93c4d2cc12da4a28303543d6d99f5f2246fde4052e84af81d18e04399b137b39e * Updates doc for Unix build: added missing dependency bison Co-authored-by: MarcoFalke <falke.marco@gmail.com>
* Fix build of qtbase in contrib for Gcc 11.x It adds a patch with missing include <limits> in qtbase/src/tools/moc/generator.cpp * Merge bitcoin#23716: test: replace hashlib.ripemd160 with an own implementation 5b559dc Swap out hashlib.ripemd160 for own implementation (Pieter Wuille) ad3e9e1 Add pure Python RIPEMD-160 (Pieter Wuille) Pull request description: Closes bitcoin#23710. ACKs for top commit: jamesob: ACK bitcoin@5b559dc, pending CI Tree-SHA512: dcd4ea2027eac572f7ab0da434b081b9a5d6b78675e559258a446b4d254b29d93c4d2cc12da4a28303543d6d99f5f2246fde4052e84af81d18e04399b137b39e * Updates doc for Unix build: added missing dependency bison Co-authored-by: MarcoFalke <falke.marco@gmail.com>
* Fix build of qtbase in contrib for Gcc 11.x It adds a patch with missing include <limits> in qtbase/src/tools/moc/generator.cpp * Merge bitcoin#23716: test: replace hashlib.ripemd160 with an own implementation 5b559dc Swap out hashlib.ripemd160 for own implementation (Pieter Wuille) ad3e9e1 Add pure Python RIPEMD-160 (Pieter Wuille) Pull request description: Closes bitcoin#23710. ACKs for top commit: jamesob: ACK bitcoin@5b559dc, pending CI Tree-SHA512: dcd4ea2027eac572f7ab0da434b081b9a5d6b78675e559258a446b4d254b29d93c4d2cc12da4a28303543d6d99f5f2246fde4052e84af81d18e04399b137b39e * Updates doc for Unix build: added missing dependency bison Co-authored-by: MarcoFalke <falke.marco@gmail.com>
Fixed build for libraries qtbase
Added missing dependency
byacc
needed to build libxcbcommonFixed functional tests due to missing function ripemd160 (backport from bitcoin test: replace hashlib.ripemd160 with an own implementation bitcoin/bitcoin#23716):