-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: convert semantic pr title check to use action #5071
ci: convert semantic pr title check to use action #5071
Conversation
trivial | ||
backport | ||
# Configure which scopes are allowed (newline delimited). | ||
scopes: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible to eliminate the scopes section here. In that case it would check the types, but allow any scope. I don't think we want to do that, but it's an option 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK for squash merge
Issue being fixed or feature implemented
The previously used service https://github.com/zeke/semantic-pull-requests was deprecated by the time we actually updated the master branch. This converts to using a GitHub action to enforce conventional commit syntax for PR titles in alignment with our contributing guide.
Notes
pull_request_target
amannn/action-semantic-pull-request#182. As I understand it, this shouldn't introduce any issues.What was done?
Although the contributing guide indicated conventional commit syntax should be used for PR titles, nothing was enforcing it. This PR adds a GitHub Action (semantic-pull-request) that checks PR titles to make sure they match the relevant format and type/scope criteria.
How Has This Been Tested?
Tested using thephez#5 in my fork of this repo. See https://github.com/thephez/dash/actions/workflows/semantic-pull-request.yml for results of various attempts.
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only