refactor: using C++11/14/17 features in dash specifict code #5190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
UdjinM6
requested changes
Feb 8, 2023
Member
|
(Also, please address CI failures) |
Co-authored-by: Pasta <pasta@dashboost.org
Collaborator
Author
This changes are dropped, because confusion about size_t type in pushKV in univalue.h Should be done after this backport: |
Co-authored-by: Pasta <pasta@dashboost.org>
Co-authored-by: Pasta <pasta@dashboost.org>
Co-authored-by: Pasta <pasta@dashboost.org>
PastaPastaPasta
approved these changes
Feb 19, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This refactoring helps to make code more specific and clear.
There's using syntax feature from modern C++ such as 'enum class', structure bindings in loops, declaration variables inside if/switch statements, etc.
What was done?
This PR is based on @PastaPastaPasta 's PR #4472
There excluded changes related to using std::optional. Let's decide firstly about
Resultclass: #5109How Has This Been Tested?
Run unit/functional tests
Breaking Changes
No breaking changes
Checklist: