docs: restore non-depends build documentation #5345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
requested changes
Apr 24, 2023
There was a problem hiding this comment.
👍
linter complains https://gitlab.com/dashpay/dash/-/jobs/4166362049 - contrib/install_db4.sh needs more work
|
Linter fails still |
|
I lean towards saying we should make sure these docs work before merging in :) |
|
This pull request has conflicts, please rebase. |
|
rebasing to pull in 5394 |
PastaPastaPasta
force-pushed
the
docs_restore
branch
from
ebe71f4 to
dcae0b2
Compare
This reverts commit 407bacc.
kwvg
force-pushed
the
docs_restore
branch
2 times, most recently
from
aba53c9 to
86d3ebd
Compare
kwvg
force-pushed
the
docs_restore
branch
3 times, most recently
from
d243609 to
c925ed8
Compare
…disable Win32 PE support
contains portions of: - bitcoin@1ac454a - bitcoin@3352da8 - bitcoin@fac86ac - bitcoin@8c9b8a3 Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
After #5077, Dash is no longer tied to the its
dependsand can be built from distro-obtained dependencies as it was before. Work on re-aligning Dash's build system with Bitcoin's has been documented in https://github.com/dashpay/dash-issues/issues/51. This PR aims to realign build documentation with upstream.Notes
revert: revert dash#2323 (Update build documentation)is not a true revert as after dash#2323, backports were done (source), including but not limited to, documentation updates for OpenSSL removal, SQLite &libnatpmpintroduction and formatting changes.That revert commit attempts to preserve the spirit of the backports done after it while reverting the
depends-centric documentation changes but as a result, changes may be misattributed and so closer review is requested.bisonis a dependency needed for building depends (as visible here) but isn't required to builddash-qtif building from dependencies sourced from your distro's package manager.Despite that,
bisonhas been retained as a dependency for now based on feedback.