fix: reset chainman to allow reindex on failure #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
reviewed
May 31, 2023
| @@ -2022,6 +2022,8 @@ bool AppInitMain(const CoreContext& context, NodeContext& node, interfaces::Bloc | |||
| LOCK(cs_main); | |||
| node.evodb.reset(); | |||
| node.evodb = std::make_unique<CEvoDB>(nEvoDbCache, false, fReset || fReindexChainState); | |||
|
|
|||
| chainman.Reset(); | |||
There was a problem hiding this comment.
why don't reset pointer also to be sure that all destructors will be called too?
p.s. seems are Reset() already does everything properly and likely it would be like that in future, so, that's sufficient enough.... Just think like using RAII [when possible] is better because no hidden non-reinizialized data remains.
|
This pull request has conflicts, please rebase. |
current develop fails with `should not be overwriting a chainstate`
UdjinM6
force-pushed
the
fix_reindex_on_failure
branch
from
071a732
to
820de6c
Compare
PastaPastaPasta
approved these changes
Jun 6, 2023
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 11, 2023
current develop fails to reindex whenever there is an issue at node
start (prints `should not be overwriting a chainstate` in `debug.log`)
reset chainman to allow it re-initialize chainstate
simulated an issue with
```
if (!fReset) {
strLoadError = _("DEBUG");
break;
}
```
should not be any but pls test
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone _(for repository
code-owners and collaborators only)_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
current develop fails to reindex whenever there is an issue at node start (prints
should not be overwriting a chainstateindebug.log)What was done?
reset chainman to allow it re-initialize chainstate
How Has This Been Tested?
simulated an issue with
Breaking Changes
should not be any but pls test
Checklist: