Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct createwallet help #5407

Merged
merged 1 commit into from
May 31, 2023

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented May 31, 2023

Issue being fixed or feature implemented

Dash does not have sethdseed, but the help mentioned it.

What was done?

Switched to upgradetohd.

How Has This Been Tested?

Breaking Changes

N/A

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Dash does not have sethdseed, but upgradetohd can be used
UdjinM6
UdjinM6 previously approved these changes May 31, 2023
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 added this to the 19.2 milestone May 31, 2023
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta changed the title chore: correct createwallet help docs: correct createwallet help May 31, 2023
@PastaPastaPasta
Copy link
Member

Bad! You tried merging into master! Bad @thephez; Bad!

@PastaPastaPasta PastaPastaPasta changed the base branch from master to develop May 31, 2023 16:55
@PastaPastaPasta PastaPastaPasta dismissed stale reviews from UdjinM6 and themself May 31, 2023 16:55

The base branch was changed.

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK :)

@PastaPastaPasta PastaPastaPasta merged commit 3526a84 into dashpay:develop May 31, 2023
@thephez
Copy link
Collaborator Author

thephez commented May 31, 2023

Bad! You tried merging into master! Bad @thephez; Bad!

HA! Almost got you. 😛

Or I just didn't notice it selecting the default branch

@thephez thephez deleted the create-wallet-help branch May 31, 2023 17:01
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 11, 2023
## Issue being fixed or feature implemented
Dash does not have `sethdseed`, but the help mentioned it.

## What was done?
Switched to `upgradetohd`.

## How Has This Been Tested?

## Breaking Changes
N/A

## Checklist:
_Go over all the following points, and put an `x` in all the boxes that
apply._
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation
- [ ] I have assigned this pull request to a milestone _(for repository
code-owners and collaborators only)_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants