fix: Various small fixes #5425
Merged
fix: Various small fixes #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luckily, in both cases we never check for type/version in serialization of any underlying type for all the values hashed there, so serialization stays the same. And hashing isn't affected by type/version either. To confirm this, I reindexed on testnet with |
PastaPastaPasta
approved these changes
Jun 12, 2023
we should be truncating after (potentially) adding new element, not before we even tried to do so
…NJOIN_SALT` keys as unknown Before: `Unknown wallet records: 2` After: `Unknown wallet records: 0`
this fix is for tray icon menu
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 12, 2023
fix: Various small fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Fix various issues/crashes. These commits are mostly tiny/trivial so I thought it might be a good idea to just dump them in one PR and merge w/o squashing. Feel free to suggest otherwise :)
What was done?
Pls see individual commits
How Has This Been Tested?
run tests, run qt
Breaking Changes
n/a
Checklist: