feat(qt): refresh the whole wallet instead of processing individual updates for huge notification queues #5453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updates for huge notification queues
UdjinM6
changed the title
| { | ||
| if (vQueueNotifications.size() - i <= 10) { | ||
| bool invoked = QMetaObject::invokeMethod(ttm, "setProcessingQueuedTransactions", Qt::QueuedConnection, Q_ARG(bool, false)); | ||
| if (vQueueNotifications.size() < 10000) { |
There was a problem hiding this comment.
can you justify this magic number a bit more? why not 500 or 1k or 100k?
There was a problem hiding this comment.
Processing 10K notifications worked ok-ish, with a slight delay for my 500k+ txes wallet. Processing 50-100k was already too slow comparing to refreshing the wallet instead. So I just kept 10k as a threshold. Could be higher or could be lower on different machines I guess, not sure how to pick the right number here.
PastaPastaPasta
previously approved these changes
Jun 26, 2023
knst
reviewed
Jun 26, 2023
| @@ -82,6 +83,7 @@ class TransactionTablePriv | |||
| } | |||
| } | |||
| } | |||
| parent->endResetModel(); | |||
There was a problem hiding this comment.
would it be a valid state of parent if an exception would be thrown before endResetModel() is called?
There was a problem hiding this comment.
Hmm.. Not sure I get the question.. What kind of exception? And why you think it should affect parent (TransactionTableModel*)?
There was a problem hiding this comment.
https://doc.qt.io/qt-6/qabstractitemmodel.html#endResetModel
You must call this function after resetting any internal data structure in your model or proxy model.
I see that some methods doesn't have noexcept specifier, more over functions between beginResetModel() and endResetModel() such as getWalletTxs, showTransaction have allocation inside: it means that any time an exception can be thrown.
There're two possible solution for resolve "you must call" request:
- write a wrapper such as
lock_guardthat will call endResetModel() in a destructor. - wrap everything between begin & endResetModel to try-catch and safely call
endResetModel
UdjinM6
dismissed stale reviews from PastaPastaPasta and ogabrielides
via
3ccd0a5
PastaPastaPasta
approved these changes
Jun 28, 2023
UdjinM6
added a commit
to UdjinM6/dash
that referenced
this pull request
Jul 25, 2023
…pdates for huge notification queues (dashpay#5453) ## Issue being fixed or feature implemented It's super slow for wallets with 100.000s of txes to process lots of notifications produced by rescan. Skip them all and simply refresh the whole wallet instead. In my case (500k+ txes testnet wallet) gui update after `rescanblockchain` time is down from _forever_ to ~30 seconds. Same for `wipewallettxes true` (dashpay#5451 ). Gui update after `wipewallettxes`/`wipewallettxes false` is instant (cause there are no txes anymore) vs _forever_ before the patch. ## What was done? refresh the whole wallet when notification queue is above 10K operations actual changes (ignoring whitespaces): dashpay@d013cb4?w=1 ## How Has This Been Tested? running on top of dashpay#5451 and dashpay#5452 , wiping and rescanning w/ and w/out this patch. ## Breaking Changes should be none ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
Dec 6, 2024
d296005 fix(qt): allow refreshing wallet data without crashing (UdjinM6) Pull request description: ## Issue being fixed or feature implemented We re-use `refreshWallet` method to optimise loading for huge wallets #5453. However gui121 backport (via 25f87b9) added a condition that prevents this logic. Fix it by allowing explicit wallet refresh (force=true). ## What was done? ## How Has This Been Tested? Open a wallet with 10k+ txes, do `rescanblockchain` via rpc console ## Breaking Changes ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK d296005; Tree-SHA512: d308b3fe9c4fbbfbf2e2339aa14c825aa6f69c72d1f04dab7a14dc1c8721138beca47c7b3801db9782d6cecf2c54023a19a6d22e04b84615f9bddb0b8ec1696c
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 6, 2024
…shing d296005 fix(qt): allow refreshing wallet data without crashing (UdjinM6) Pull request description: ## Issue being fixed or feature implemented We re-use `refreshWallet` method to optimise loading for huge wallets dashpay#5453. However gui121 backport (via 25f87b9) added a condition that prevents this logic. Fix it by allowing explicit wallet refresh (force=true). ## What was done? ## How Has This Been Tested? Open a wallet with 10k+ txes, do `rescanblockchain` via rpc console ## Breaking Changes ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK d296005; Tree-SHA512: d308b3fe9c4fbbfbf2e2339aa14c825aa6f69c72d1f04dab7a14dc1c8721138beca47c7b3801db9782d6cecf2c54023a19a6d22e04b84615f9bddb0b8ec1696c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
It's super slow for wallets with 100.000s of txes to process lots of notifications produced by rescan. Skip them all and simply refresh the whole wallet instead. In my case (500k+ txes testnet wallet) gui update after
rescanblockchaintime is down from forever to ~30 seconds. Same forwipewallettxes true(#5451 ). Gui update afterwipewallettxes/wipewallettxes falseis instant (cause there are no txes anymore) vs forever before the patch.What was done?
refresh the whole wallet when notification queue is above 10K operations
actual changes (ignoring whitespaces): d013cb4?w=1
How Has This Been Tested?
running on top of #5451 and #5452 , wiping and rescanning w/ and w/out this patch.
Breaking Changes
should be none
Checklist: