Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Testnet syncing mn_rr #5608

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: Testnet syncing mn_rr #5608

merged 1 commit into from
Oct 9, 2023

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Oct 9, 2023 •
edited
Loading

Issue being fixed or feature implemented

Since mn_rr is already active on Testnet, because of #5588, syncing from develop is broken.

What was done?

Temporary disabled changes of #5588 for Testnet.
This should be dropped when Testnet will be re-organised for Platform.

How Has This Been Tested?

Syncing Testnet

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@ogabrielides ogabrielides added this to the 20 milestone Oct 9, 2023
PastaPastaPasta
PastaPastaPasta approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK for squash merge; Reindexed testnet successfully

UdjinM6
UdjinM6 approved these changes Oct 9, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK (affecting testnet only so 🤷‍♂️ )

thephez
thephez approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced okay for me 👍

@PastaPastaPasta PastaPastaPasta merged commit bf84e37 into dashpay:develop Oct 9, 2023
10 checks passed
@ogabrielides ogabrielides deleted the testnet_mn_rr branch October 9, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thephez thephez thephez approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@knst knst Awaiting requested review from knst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20
Development

Successfully merging this pull request may close these issues.
4 participants
@ogabrielides @UdjinM6 @PastaPastaPasta @thephez