Skip to content

fix: actually use to_calculate stack in CMNHFManager::GetForBlock #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UdjinM6 merged 1 commit into from
Dec 4, 2023
Merged

fix: actually use to_calculate stack in CMNHFManager::GetForBlock #5747

UdjinM6 merged 1 commit into from
Dec 4, 2023

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Dec 1, 2023

Issue being fixed or feature implemented

Fixes a bug we missed in #5736

What was done?

Use all collected indexes, not just the last one

How Has This Been Tested?

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 20.1 milestone Dec 1, 2023
knst
knst approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@knst knst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Also it works for my broken storage (no more MNEHF assert happens)
Let me test later on my broken index

PastaPastaPasta
PastaPastaPasta approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@UdjinM6 UdjinM6 merged commit 72d4c51 into dashpay:develop Dec 4, 2023
@UdjinM6 UdjinM6 modified the milestones: 20.1, 20.0.2 Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knst knst knst approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

20.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6 @knst @PastaPastaPasta