Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable HD wallets by default #5807

Merged
merged 10 commits into from
Feb 9, 2024
Merged

feat: enable HD wallets by default #5807

merged 10 commits into from
Feb 9, 2024

Commits on Jan 25, 2024

  1. feat: use HD wallets by default

    @knst
    knst committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    4ae116d View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. fix: now HD wallet can be created from the scratch by default

    @knst
    knst committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    4620a0e View commit details
    Browse the repository at this point in the history

  2. fix: functional test wallet_upgradewallet.py works now!

    @knst
    knst committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    2a5a08d View commit details
    Browse the repository at this point in the history

  3. feat: forbid wallet upgrade from non-HD to HD by upgradewallet

    @knst
    knst committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    3de3c7e View commit details
    Browse the repository at this point in the history

  4. refactor: move upgradetohd implementation from rpcwallet to wallet. 

    RPC upgradetohd keeps only rpc's related code same as upgradewallet RPC
same as bitcoin#15761
    @knst
    knst committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    bfec081 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. chore: wallet_upgadewallet.py to use the oldest supported dash version 

    Version is changed from 19.3.0 to 0.16.1.1
Even older doesn't support importing private coinbase key at the moment.

Version 20.x is also changed to 18.2 to the latest which do not create wallets
by default for sack of unification with bitcoin and to fix issue with `createwallet`
rpc which is subject to change once descriptor wallets would be backported.
    @knst
    knst committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c7ee63d View commit details
    Browse the repository at this point in the history

  2. chore: encourage users to encrypt wallets

    @knst
    knst committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b698a9f View commit details
    Browse the repository at this point in the history

  3. chore: postpone breaking changes of wallet_upgradewallet to v21

    @knst
    knst committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    af49d5a View commit details
    Browse the repository at this point in the history

  4. suggestions

    @UdjinM6 @knst
    UdjinM6 authored and knst committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    8c29608 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. docs: add release notes

    @knst
    knst committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    73b5372 View commit details
    Browse the repository at this point in the history