fix: revive IsQuorumTypeEnabled logic dropped in 5790 #5841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PastaPastaPasta
approved these changes
Jan 28, 2024
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
knst
reviewed
Jun 30, 2024
| if (Params().NetworkIDString() == CBaseChainParams::TESTNET) return true; | ||
| return !fDIP0024IsActive; | ||
|
|
||
| return !fDIP0024IsActive || !fHaveDIP0024Quorums || |
Collaborator
There was a problem hiding this comment.
this line should not be changed, should it?
Author
There was a problem hiding this comment.
note // fall through here b8a086d#diff-cf3d9716cca5e57a6033574399f5be8a184f017da2c02c414ae2771c101a2339R870
Collaborator
There was a problem hiding this comment.
yes, indeed, it has been changed in #5790 and reverted later in 5841 (this PR).
Both RRs are between v20.0.4 and v20.1, so, it should not affect then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
developcan't sync from genesis on mainnet, b8a086d broke it.#5790 follow-up
What was done?
Revive the old logic but using hardcoded block heights instead of scanning via quorum manager.
How Has This Been Tested?
Synced on mainnet/testnet, CI is happy https://gitlab.com/UdjinM6/dash/-/pipelines/1148980046.
Breaking Changes
n/a
Checklist: