Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move HD code from CWallet to LegacyScriptPubKeyMan #5854

Merged
merged 15 commits into from
Mar 5, 2024
Merged

refactor: move HD code from CWallet to LegacyScriptPubKeyMan #5854

merged 15 commits into from
Mar 5, 2024

Conversation

knst
Copy link
Collaborator

@knst knst commented Jan 31, 2024 •
edited
Loading

Issue being fixed or feature implemented

During backport bitcoin#17261 significant part of HD chain has been forgotten in CWallet due to our own implementation.

This PR do not change behaviour of HD wallets, it's just refactoring.

What was done?

This PR refactor HD wallets implementation:

How Has This Been Tested?

Run unit/functional tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 20.1 milestone Jan 31, 2024
@knst knst mentioned this pull request Jan 31, 2024
Merged
5 tasks
@PastaPastaPasta PastaPastaPasta marked this pull request as draft February 5, 2024 16:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

This pull request has conflicts, please rebase.

@knst knst marked this pull request as ready for review February 12, 2024 15:41
UdjinM6
UdjinM6 reviewed Feb 12, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 Will test it a bit

src/wallet/scriptpubkeyman.cpp Outdated Show resolved Hide resolved
UdjinM6
UdjinM6 previously approved these changes Feb 13, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

light ACK

UdjinM6
UdjinM6 previously approved these changes Feb 14, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please rebase.

UdjinM6
UdjinM6 approved these changes Feb 25, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@UdjinM6 UdjinM6 modified the milestones: 20.1, 21 Mar 5, 2024
@knst
Copy link
Collaborator Author

knst commented Mar 5, 2024

@knst knst force-pushed the hd-1 branch from d0f309f to b5f4411

rebased to be on top of post-merged master to develop

PastaPastaPasta
PastaPastaPasta approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit 8459820 into dashpay:develop Mar 5, 2024
4 of 7 checks passed
@knst knst mentioned this pull request Mar 5, 2024
Merged
5 tasks
@knst knst deleted the hd-1 branch March 6, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21
Development

Successfully merging this pull request may close these issues.
3 participants
@knst @UdjinM6 @PastaPastaPasta