Skip to content

backport: bitcoin#19528, #19455, #19717, #19849, #19994 - assert for RPCArg names #5936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 12 commits into from
Mar 18, 2024
Merged

backport: bitcoin#19528, #19455, #19717, #19849, #19994 - assert for RPCArg names #5936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
58d923c
Merge #19528: rpc: Assert that RPCArg names are equal to CRPCCommand …
Aug 14, 2020
41c35fd
fix: adjust missing arguments and help for misc rpc: debug, echo, mnsync
knst Feb 24, 2024
860d31f
Merge #19455: rpc generate: print useful help and error message
laanwj Aug 14, 2020
7ac1ee0
Merge #19717: rpc: Assert that RPCArg names are equal to CRPCCommand …
Aug 31, 2020
f525f57
fix: follow-up missing changes from Merge #18607: rpc: Fix named argu…
knst Feb 25, 2024
c30c8f2
Merge #19849: Assert that RPCArg names are equal to CRPCCommand ones …
Sep 22, 2020
af9eb81
fix: wrong name of arguments for RPC
knst Feb 26, 2024
0e1a311
Merge #19994: Assert that RPCArg names are equal to CRPCCommand ones …
Sep 23, 2020
d016354
refactor: use new format CPCCommand for rpc/coinjoin
knst Mar 13, 2024
b54f03a
fix: wrong name of argument for coinjoin
knst Mar 13, 2024
3621966
feat: add todo to drop Throw() from rpc/util.h
knst Mar 13, 2024
c503168
fix: rename arguments for 'voteraw'
knst Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/rest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ static bool rest_block_notxdetails(const CoreContext& context, HTTPRequest* req,
}

// A bit of a hack - dependency on a function defined in rpc/blockchain.cpp
UniValue getblockchaininfo(const JSONRPCRequest& request);
RPCHelpMan getblockchaininfo();

static bool rest_chaininfo(const CoreContext& context, HTTPRequest* req, const std::string& strURIPart)
{
Expand All @@ -347,7 +347,7 @@ static bool rest_chaininfo(const CoreContext& context, HTTPRequest* req, const s
case RetFormat::JSON: {
JSONRPCRequest jsonRequest(context);
jsonRequest.params = UniValue(UniValue::VARR);
UniValue chainInfoObject = getblockchaininfo(jsonRequest);
UniValue chainInfoObject = getblockchaininfo().HandleRequest(jsonRequest);
std::string strJSON = chainInfoObject.write() + "\n";
req->WriteHeader("Content-Type", "application/json");
req->WriteReply(HTTP_OK, strJSON);
Expand Down
Loading