Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: Merge bitcoin#21718, 21759, 21872 #5989

Merged
merged 3 commits into from
May 19, 2024
Merged

backport: Merge bitcoin#21718, 21759, 21872 #5989

merged 3 commits into from
May 19, 2024

Commits on May 19, 2024

  1. Merge bitcoin#21718: rpc: Improve error message for getblock invalid … 

    …datatype.

a411494 rpc: Improve getblock error message for invalid data type. (klementtan)

Pull request description:

  Improve error messages for getblock invalid datatype.

  fixes: bitcoin#21717

ACKs for top commit:
  instagibbs:
    utACK bitcoin@a411494
  theStack:
    ACK a411494
  promag:
    Code review ACK a411494.

Tree-SHA512: 6e7d8290681e8ab375629f81669d0f8e0c21f9eb7ed9e2455cd19ea013e69b2d95fa7a9ee795315b2d5c60c96035c6cefc3d6e1039a06fd88c1dc7fe275ee6a1
    @fanquake @PastaPastaPasta
    fanquake authored and PastaPastaPasta committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ea347e6 View commit details
    Browse the repository at this point in the history

  2. Merge bitcoin#21759: wallet: document coin selection code 

    6ba8921 refactor + document coin selection strategy (glozow)
58ea324 [docs] add doxygen comments to wallet code (glozow)
0c74716 [docs] format existing comments as doxygen (glozow)

Pull request description:

  I think it would help code review to have more documentation + doxygen comments

ACKs for top commit:
  Xekyo:
    ReACK bitcoin@6ba8921
  achow101:
    ACK 6ba8921

Tree-SHA512: 74a78d9b0e0c1d5659bed566432a5b3511511d8b2432f440565f443da7b8257a1b90e70aa7505a7f8abf618748eeb43d166e84f278bdee3d34ce5d5c37dc573a
    @fanquake @PastaPastaPasta
    fanquake authored and PastaPastaPasta committed May 19, 2024
    Configuration menu
    Copy the full SHA
    be9781d View commit details
    Browse the repository at this point in the history

  3. Merge bitcoin#21872: net: Sanitize message type for logging 

    09205b3 net: Clarify message header validation errors (W. J. van der Laan)
955eee7 net: Sanitize message type for logging (W. J. van der Laan)

Pull request description:

  - Use `SanitizeString` when logging message errors to make sure that the message type is sanitized. I have checked all logging in `net.cpp`.

  - For the `MESSAGESTART` error don't inspect and log header details at all: receiving invalid start bytes makes it likely that the packet isn't even formatted as valid P2P message. Logging the four unexpected start bytes (as hex) should be enough.

  - Update `p2p_invalid_messages.py` test to check this.

  - Improve error messages in a second commit.

  Issue reported by gmaxwell.

ACKs for top commit:
  MarcoFalke:
    re-ACK 09205b3 only change is log message fixup 🔂
  practicalswift:
    re-ACK 09205b3

Tree-SHA512: 8fe5326af135cfcf39ea953d9074a8c966b9b85a810b06a2c45b8a745cf115de4f321e72fc769709d6bbecfc5953aab83176db6735b04c0bc6796f59272cadce
    @PastaPastaPasta
    MarcoFalke authored and PastaPastaPasta committed May 19, 2024
    Configuration menu
    Copy the full SHA
    00e556a View commit details
    Browse the repository at this point in the history