refactor: use = with ENV in dockerfiles
#6196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
reviewed
Aug 12, 2024
contrib/guix/Dockerfile
Outdated
| @@ -15,12 +15,12 @@ ARG guix_checksum_aarch64=72d807392889919940b7ec9632c45a259555e6b0942ea7bfd13110 | |||
| ARG guix_checksum_x86_64=236ca7c9c5958b1f396c2924fcc5bc9d6fdebcb1b4cf3c7c6d46d4bf660ed9c9 | |||
| ARG builder_count=32 | |||
|
|
|||
| ENV PATH /root/.config/guix/current/bin:$PATH | |||
| ENV PATH=/root/.config/guix/current/bin:$PATH | |||
There was a problem hiding this comment.
let's add "" also?
Suggested change
| ENV PATH=/root/.config/guix/current/bin:$PATH | |
| ENV PATH="/root/.config/guix/current/bin:$PATH" |
because previous PATH can have not only alpha-numeric characters
There was a problem hiding this comment.
makes sense to me
knst
reviewed
Aug 12, 2024
| @@ -5,11 +5,11 @@ LABEL description="Dockerised DashCore, built from CI" | |||
| ARG USER_ID | |||
| ARG GROUP_ID | |||
|
|
|||
| ENV HOME=/home/dash | |||
| ENV HOME="/home/dash" | |||
There was a problem hiding this comment.
this particular case no really need quotes :D
There was a problem hiding this comment.
well you told me to add quotes!
knst
approved these changes
Aug 12, 2024
UdjinM6
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
see: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
Basically avoid old format of ENV in docker files
What was done?
see commit
How Has This Been Tested?
Building the containers locally, seems all fine
Breaking Changes
Please describe any breaking changes your code introduces
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.