test: a simpler way to disable mocktime in p2p_initial_headers_sync.py#6235
Closed
UdjinM6 wants to merge 1 commit intodashpay:developfrom
Closed
test: a simpler way to disable mocktime in p2p_initial_headers_sync.py#6235UdjinM6 wants to merge 1 commit intodashpay:developfrom
p2p_initial_headers_sync.py#6235UdjinM6 wants to merge 1 commit intodashpay:developfrom
Conversation
knst
approved these changes
Aug 30, 2024
| self._initialize_chain_clean() | ||
| else: | ||
| self._initialize_chain() | ||
| def setup_network(self): |
Collaborator
There was a problem hiding this comment.
Using setup_network() seems as an ugly solution. Let's add this refactoring better.
If you think that's out-of-scope PR I will create a new PR
Author
There was a problem hiding this comment.
Let's see if CI is happy there and if it is I'm just going to close this one in fav of yours.
5 tasks
Author
|
closing in fav of #6242 |
PastaPastaPasta
added a commit
that referenced
this pull request
Sep 4, 2024
…rams() ef4d74a test: remove dead code from `p2p_initial_headers_sync.py` to favor of disable mocktime (UdjinM6) 4d9837c refactor: add a new flag disable_mocktime to set_test_params() (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented To disable mocktime you should re-implement setup_nodes(). It seems as bug-friendly solution ## What was done? This PR introduce a new flag "disable_mocktime" which can be set in `set_test_params`. It seems more error prune and the code is shorter ## How Has This Been Tested? Run unit/functional tests including future changes from #6235 ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: utACK ef4d74a kwvg: utACK ef4d74a PastaPastaPasta: utACK ef4d74a Tree-SHA512: c6be8002cae4d7824e150938957464c156931d0b6f7fc41c430a83d662865431f1b56cb11df73f56db54a140f36b0addd68b2917e25c5c941fae52e8d322bc25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
simplify mocktime disabling in
p2p_initial_headers_sync.pyWhat was done?
How Has This Been Tested?
run
p2p_initial_headers_sync.pyBreaking Changes
n/a
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.