Skip to content

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented Sep 10, 2024

Additional Information

Would allow tagging #5167, #6267 and #6237 as feat(stats).

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code (note: N/A)
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only) (note: N/A)

@thephez
Copy link
Collaborator

thephez commented Sep 10, 2024

Additional Information

Would allow tagging dash#5167 and its successor PR as feat(stats) and dash#6237 as stats.

I think you'll be fine since we've changed the default branch to develop. But if it doesn't work as expected it, check for where it actually runs from.

For reference: looks like the original PR mentioned it using the default branch for the config. So you shouldn't have to wait for it to get to master 🙂

knst
knst previously approved these changes Sep 11, 2024
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM a6f7339b9d3b842ba6fb7241c39e50bd8ab1adb2

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 4faf35f

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 4faf35f

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
utACK 4faf35f

@PastaPastaPasta PastaPastaPasta merged commit f2645df into dashpay:develop Sep 11, 2024
@UdjinM6 UdjinM6 added this to the 21.2 milestone Sep 11, 2024
@UdjinM6 UdjinM6 modified the milestones: 21.2, 22 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants