Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start DIP0024 from block 1, backport bitcoin#24527, bitcoin#23086 - fire up test chains by first block - 7/n #6325

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Commits on Nov 21, 2024

  1. fix: assertion in Credit Pool validation during connecting blocks

    It can happen because now order of activation of hardforks v20, mn_rr, dip3
    can be changed by using testactivationheight on Regtest and no more
    guarantee about this assertions
    knst committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d900ab3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1730ac3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7ece22d View commit details
    Browse the repository at this point in the history
  4. refactor: remove command line argument -bip147height, -dip8params

    bip147height is superseeded by -testactivationheight=bip147@height
    dip8params is superseeded by -testactivationheight=dip0008@height
    knst committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0ea0c27 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Configuration menu
    Copy the full SHA
    03a5327 View commit details
    Browse the repository at this point in the history
  2. feat: re-bury DIP0024 with new height when quorums actually appeared

    For current implementation it is not important when exactly fork happened
    yet important to know when first rotating quorum formed
    knst committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    31abe44 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f3a96ce View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    629d0e6 View commit details
    Browse the repository at this point in the history
  5. Merge bitcoin#23086: test: Add -testactivationheight tests to rpc_blo…

    …ckchain
    
    fa4ca8d test: Add -testactivationheight tests to rpc_blockchain (MarcoFalke)
    
    Pull request description:
    
      Suggested: bitcoin#22818 (comment)
    
    ACKs for top commit:
      laanwj:
        Code review ACK fa4ca8d
      theStack:
        Concept and code-review ACK fa4ca8d
    
    Tree-SHA512: 41304db1a15c0c705a9cc2808c9f1d7831a321a8a7948a28ec5d3ee1ed3da6a0ce67cd50c99a33aaed86830c59608eb6ffadbeaba67d95245c490f9b6c277912
    merge-script authored and knst committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f0ff942 View commit details
    Browse the repository at this point in the history
  6. Merge bitcoin#24527: test: set segwit height back to 0 on regtest

    5ce3057 test: set segwit height back to 0 on regtest (Martin Zumsande)
    
    Pull request description:
    
      The change of `consensus.SegwitHeight` from 0 to 1 for regtest in bitcoin#22818 had the effect that if I create a regtest enviroment with  current master (or 23.x), and then try to load this chain with an older version (22.x), I get an InitError
      `Witness data for blocks after height 0 requires validation. Please restart with -reindex`
      and have to reindex because `BLOCK_OPT_WITNESS` is no longer set for the Genesis block and `NeedsRedownload()` in validation returns `true` with an older version.
      That might be a bit annoying for tests that use a shared regtest dir with different versions.
    
      If people think this is enough of an issue to be worth fixing, I think it should also make it into 23.x
    
    ACKs for top commit:
      theStack:
        Concept and code-review ACK 5ce3057
    
    Tree-SHA512: b0e89ff7fc953bc0ae929d2da44cde7149321d987fb4763934f6c9635d00d807129a50b459cc5e69e86bb1819e4b063b969486e8016a1cb8db8f905fa315653d
    MarcoFalke authored and knst committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    5e6a58a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bb60941 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0b3ce03 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cd2f39a View commit details
    Browse the repository at this point in the history