Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use actions/cache to manage depends cache #6406

Merged
merged 1 commit into from
Nov 19, 2024
Merged

ci: use actions/cache to manage depends cache #6406

merged 1 commit into from
Nov 19, 2024
+9 −12

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Nov 19, 2024 •
edited
Loading

Additional Information

Breaking Changes

None expected.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 22.1 milestone Nov 19, 2024
@kwvg
Copy link
Collaborator Author

kwvg commented Nov 19, 2024

GitHub Actions run for 9a29252, https://github.com/kwvg/dash/actions/runs/11916627341. Qt builds as expected, see here.

@kwvg kwvg marked this pull request as ready for review November 19, 2024 16:41
@UdjinM6 UdjinM6 modified the milestones: 22.1, 22 Nov 19, 2024
PastaPastaPasta
PastaPastaPasta requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept NACK, discussed on call, should avoid deleting cache's for keys as GitHub Actions cache's are designed to be immutable.

@kwvg
Copy link
Collaborator Author

kwvg commented Nov 19, 2024 •
edited
Loading

GitHub Actions run 6fbd34c, https://github.com/kwvg/dash/actions/runs/11918168390. Qt builds as expected, see here.

EDIT: 6fbd34c, 087de7f and 9cc29a8 should be identical to each other (see diff #1 and diff #2), only change is commit text

@kwvg kwvg changed the title ci: use actions/cache for restore/save cache, gh for deleting cache ci: use actions/cache to manage depends cache Nov 19, 2024
PastaPastaPasta
PastaPastaPasta approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 087de7f

@kwvg @PastaPastaPasta
ci: use actions/cache to manage depends cache
9cc29a8 
Co-authored-by: pasta <pasta@dashboost.org>
PastaPastaPasta
PastaPastaPasta approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9cc29a8

no diff-fp

UdjinM6
UdjinM6 approved these changes Nov 19, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9cc29a8

@PastaPastaPasta PastaPastaPasta merged commit d4c17d9 into dashpay:develop Nov 19, 2024
29 of 30 checks passed
@kwvg kwvg mentioned this pull request Nov 20, 2024
Open
5 tasks
knst pushed a commit to knst/dash that referenced this pull request Nov 26, 2024
@PastaPastaPasta @knst
Merge dashpay#6406: ci: use actions/cache to manage depends cache
3dd10a4 
9cc29a8 ci: use `actions/cache` to manage depends cache (Kittywhiskers Van Gogh)

Pull request description:

  ## Additional Information

  * Builds after [dash#6401](dashpay#6401) have silently stopped building Dash Qt, see pre-[dash#6401](dashpay#6401) `develop` (6a51ab2)'s [build](https://github.com/dashpay/dash/actions/runs/11881892222/job/33106960691#step:7:725) compared against [build \#1](https://github.com/PastaPastaPasta/dash/actions/runs/11897504945/job/33152711720#step:7:1432) and [build \dashpay#2](https://github.com/kwvg/dash/actions/runs/11898510091/job/33156186503#step:7:1432) from [dash#6401](dashpay#6401 review process.

    This pull request aims to correct that regression.

  ## Breaking Changes

  None expected.

  ## Checklist

  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**
  - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)**
  - [x] I have made corresponding changes to the documentation **(note: N/A)**
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  PastaPastaPasta:
    utACK dashpay@9cc29a8
  UdjinM6:
    utACK 9cc29a8

Tree-SHA512: 09663987696d29e12c98b48297960c7c1e6484e337ddc8311f340fee1d026ace572674e8cbca578ba743ff781caabb6fcc1853cee8ddff3e13af3fe3d0361776
knst pushed a commit to knst/dash that referenced this pull request Nov 26, 2024
@PastaPastaPasta @knst
Merge dashpay#6406: ci: use actions/cache to manage depends cache
a1f7e96 
9cc29a8 ci: use `actions/cache` to manage depends cache (Kittywhiskers Van Gogh)

Pull request description:

  ## Additional Information

  * Builds after [dash#6401](dashpay#6401) have silently stopped building Dash Qt, see pre-[dash#6401](dashpay#6401) `develop` (6a51ab2)'s [build](https://github.com/dashpay/dash/actions/runs/11881892222/job/33106960691#step:7:725) compared against [build \#1](https://github.com/PastaPastaPasta/dash/actions/runs/11897504945/job/33152711720#step:7:1432) and [build \dashpay#2](https://github.com/kwvg/dash/actions/runs/11898510091/job/33156186503#step:7:1432) from [dash#6401](dashpay#6401 review process.

    This pull request aims to correct that regression.

  ## Breaking Changes

  None expected.

  ## Checklist

  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**
  - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)**
  - [x] I have made corresponding changes to the documentation **(note: N/A)**
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  PastaPastaPasta:
    utACK dashpay@9cc29a8
  UdjinM6:
    utACK 9cc29a8

Tree-SHA512: 09663987696d29e12c98b48297960c7c1e6484e337ddc8311f340fee1d026ace572674e8cbca578ba743ff781caabb6fcc1853cee8ddff3e13af3fe3d0361776
PastaPastaPasta added a commit that referenced this pull request Nov 26, 2024
@PastaPastaPasta
Merge #6432: [v22.0.x] backport: release v22.0.0-rc2
a6ee725 
8b88ff7 Merge #6414: chore: bump seeds for v22 (pasta)
02ad523 Merge #6411: chore: update nMinimumChainWork, defaultAssumeValid, checkpointData, chainTxData for mainnet and testnet (pasta)
3bbcd3d Merge #6393: docs: mention building for some HOSTs only in `release-process.md` (pasta)
18f636f Merge #6426: fix: respect SENDDSQUEUE message, move DSQ relay into net processing / peerman (pasta)
9fed456 Merge #6407: fix: dataraces (pasta)
86105da Merge #6408: refactor: removed pre-MN_RR logic of validation of CL (pasta)
a1f7e96 Merge #6406: ci: use `actions/cache` to manage depends cache (pasta)
90a3807 Merge #6402: ci: cache built (pasta)
66f6787 Merge #6401: ci: deduplicate depends building (pasta)
7ca5663 Merge #6397: ci: add powerpc64 to GH Guix job matrix (pasta)

Pull request description:

  ## What was done?
  See commits for each particular change

  ## How Has This Been Tested?
  To be deployed on testnet

  ## Breaking Changes
  N/A

  ## Checklist:
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK 8b88ff7
  PastaPastaPasta:
    utACK 8b88ff7

Tree-SHA512: f7fac62996873503e7de875cc96d9cdf5675674345f1bb1df4a16bf19bddc17bc395a80cc761363a0121022d42c46fb313b0973b9cc71f568ef55c6b3d9e29d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@knst knst Awaiting requested review from knst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22
Development

Successfully merging this pull request may close these issues.
3 participants
@kwvg @UdjinM6 @PastaPastaPasta