refactor: move expensive CInv initialization out of hot loop #6424
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
approved these changes
Nov 21, 2024
| @@ -2328,13 +2328,13 @@ void PeerManagerImpl::RelayInvFiltered(CInv &inv, const uint256& relatedTxHash, | |||
|
|
|||
| void PeerManagerImpl::RelayTransaction(const uint256& txid) | |||
| { | |||
| const CInv inv{m_cj_ctx->dstxman->GetDSTX(txid) ? MSG_DSTX : MSG_TX, txid}; | |||
There was a problem hiding this comment.
usually it's only 10-12 peers, so, maybe improvements is non-noticeable by benchmark
There was a problem hiding this comment.
Well, no, not necessarily, MNs are highly connected. As an example on testnet
ubuntu@masternode-12:~$ dash-cli getpeerinfo | jq .[].id | wc -l
100
and only 4 of them have tx relay disabled
ubuntu@masternode-12:~$ dash-cli getpeerinfo | jq .[].relaytxes | grep false | wc -l
4
There was a problem hiding this comment.
ah yes, I completely forgot about MNs 🫣
There was a problem hiding this comment.
ah yes, I completely forgot about MNs 🫣
Careful about that, they may fire you!
UdjinM6
approved these changes
Nov 21, 2024
kwvg
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Not sure how we introduced this one, but it appears we are calling a CInv construction (pretty cheap) and a GetDSTX ((relatively) EXPENSIVE) for each peer we are connected to in RelayTransaction... I can hope and pray that the compiler somehow was magically optimizing this for us, but I really doubt it
What was done?
Move the initialization out of the loop
How Has This Been Tested?
Breaking Changes
N/A
Checklist: