Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't shrink window when setting minimum width #6471

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Dec 9, 2024

Additional Information

How Has This Been Tested?

Crossed compiled for x86_64-w64-mingw32 and tested resulting dash-qt.exe on Windows 11 22H2 (Build 22621.431). Followed reproduction steps as mentioned in dash#5886, found width to persist even after closing Options modal using buttons and the close button on the top right.

Breaking Changes

None expected.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 22.1 milestone Dec 9, 2024
@kwvg kwvg marked this pull request as ready for review December 9, 2024 15:28
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally utACK e080686

Can you describe how you tested this?

@kwvg
Copy link
Collaborator Author

kwvg commented Dec 10, 2024

Updated PR description to include testing method

Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM e080686

seems as only two mis-usage and both are covered

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e080686

@PastaPastaPasta PastaPastaPasta merged commit 8ec789f into dashpay:develop Dec 10, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants