[v22.1.x] backport: backport to and release 22.1.1#6578
Merged
PastaPastaPasta merged 4 commits intodashpay:v22.1.xfrom Feb 14, 2025
Merged
[v22.1.x] backport: backport to and release 22.1.1#6578PastaPastaPasta merged 4 commits intodashpay:v22.1.xfrom
PastaPastaPasta merged 4 commits intodashpay:v22.1.xfrom
Conversation
… when in discreet mode 21504ae fix: use proper units, show 0 rounds to reuse existing translation (UdjinM6) 5329b7d fix(qt): avoid leaking balance and CJ info in GUI when in discreet mode (UdjinM6) Pull request description: ## Issue being fixed or feature implemented develop: <img width="721" alt="Screenshot 2025-02-10 at 16 14 52" src="https://github.com/user-attachments/assets/742dc502-64c4-4c99-adb2-97009d387143" /> this PR: <img width="715" alt="Screenshot 2025-02-10 at 16 17 52" src="https://github.com/user-attachments/assets/854a8de9-2f5b-447b-b618-593ce8cf9225" /> ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 21504ae knst: utACK 21504ae Tree-SHA512: 6ac57e171f256f322479644fced8e6223eeac2813bea3d1c1e4debdb9586e3e46265fa36b5f196256dbe470a5c32ef54753a3024722b3410d9eeafa5e378b97d
…ific flags 17f0aa3 fix: ReconnectionInfo should also store Dash-specific flags (UdjinM6) Pull request description: ## Issue being fixed or feature implemented Mixing with p2p v2 protocol enabled on p2p v1 masternodes triggers reconnection which "forgets" about Dash-specific flags so these connections aren't dropped on mixing session timeouts like they should. Most nodes on testnet are upgraded so the issue wasn't noticeable there unfortunately. ## What was done? Store Dash-specific flags in `ReconnectionInfo` and use them in `PerformReconnections()` later ## How Has This Been Tested? ## Breaking Changes n/a ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: kwvg: ACK 17f0aa3 PastaPastaPasta: utACK 17f0aa3 Tree-SHA512: eb69716e79acc29529b900900d284ddd2d6565d847b1039194c8764fa4575a7a8f51e95b733dc58a550819f9cf5be11de759ceb6884ce44723ede912231cc574
PastaPastaPasta
force-pushed
the
backport-v22.1.1
branch
from
dd1367b to
4298d73
Compare
UdjinM6
approved these changes
Feb 14, 2025
kwvg
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
See commits; backport to and prep for release 22.1.1
What was done?
How Has This Been Tested?
built locally
Breaking Changes
Checklist: