[v22.1.x] backport: backport to and release 22.1.3

[PastaPastaPasta]

Issue being fixed or feature implemented

Backports for a new version, v22.1.3

What was done?

See release notes

How Has This Been Tested?

Breaking Changes

None

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[github-actions]

This pull request has conflicts, please rebase.

[coderabbitai]

Walkthrough

This set of changes updates versioning information, documentation, consensus parameters, error handling, and performance in the Dash Core project. The client version build number is incremented, and release notes are revised for version v22.1.3, with a new release note added for v22.1.2. Documentation related to translation and Transifex URLs is updated throughout. Consensus parameters for both mainnet and testnet are advanced to reflect new block heights. Error handling in masternode payment validation is improved to avoid assertion failures, while RPC index utility functions streamline error returns. Versionbits state computation is optimized with an early return when no further computation is needed.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

doc/release-notes/dash/release-notes-22.1.2.md (1)

29-35: Heading style is inconsistent with surrounding markdown

Lines 29–35 mix setext (---) and atx (#) styles; markdownlint flags this.
Consider switching the Quorum Rotation Improvements heading to atx for uniformity.

-Quorum Rotation Improvements
----------------------------
+# Quorum Rotation Improvements

doc/release-notes.md (1)

29-37: Mixed heading styles / missing blank line after atx heading

Bug Fixes (and subsequent sections) use atx ### style but are underlined with ---, which creates malformed markdown.
For consistency and to silence markdownlint, drop the underline or convert back to setext.

-Bug Fixes
-----------
+# Bug Fixes

Apply similarly to the other three section headers.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d9f52ac and 65ebca9fdc384ee94840af8bc1d27f679fe3fdcc.

📒 Files selected for processing (9)

• README.md (1 hunks)
• configure.ac (1 hunks)
• doc/release-notes.md (4 hunks)
• doc/release-notes/dash/release-notes-22.1.2.md (1 hunks)
• doc/translation_process.md (4 hunks)
• src/chainparams.cpp (2 hunks)
• src/masternode/payments.cpp (1 hunks)
• src/rpc/index_util.cpp (5 hunks)
• src/versionbits.cpp (1 hunks)

🧰 Additional context used

🧠 Learnings (5)

📓 Common learnings

Learnt from: kwvg
PR: dashpay/dash#6543
File: src/wallet/receive.cpp:240-251
Timestamp: 2025-02-06T14:34:30.466Z
Learning: Pull request #6543 is focused on move-only changes and refactoring, specifically backporting from Bitcoin. Behavior changes should be proposed in separate PRs.

Learnt from: kwvg
PR: dashpay/dash#6718
File: test/functional/test_framework/test_framework.py:2102-2102
Timestamp: 2025-06-09T16:43:20.996Z
Learning: In the test framework consolidation PR (#6718), user kwvg prefers to limit functional changes to those directly related to MasternodeInfo, avoiding scope creep even for minor improvements like error handling consistency.

src/masternode/payments.cpp (5)

Learnt from: kwvg
PR: dashpay/dash#6718
File: test/functional/test_framework/test_framework.py:2102-2102
Timestamp: 2025-06-09T16:43:20.996Z
Learning: In the test framework consolidation PR (#6718), user kwvg prefers to limit functional changes to those directly related to MasternodeInfo, avoiding scope creep even for minor improvements like error handling consistency.

Learnt from: kwvg
PR: dashpay/dash#6529
File: src/wallet/rpcwallet.cpp:3002-3003
Timestamp: 2025-02-14T15:19:17.218Z
Learning: The `GetWallet()` function calls in `src/wallet/rpcwallet.cpp` are properly validated with null checks that throw appropriate RPC errors, making additional validation unnecessary.

Learnt from: kwvg
PR: dashpay/dash#6543
File: src/wallet/receive.cpp:240-251
Timestamp: 2025-02-06T14:34:30.466Z
Learning: Pull request #6543 is focused on move-only changes and refactoring, specifically backporting from Bitcoin. Behavior changes should be proposed in separate PRs.

Learnt from: kwvg
PR: dashpay/dash#6665
File: src/evo/providertx.h:82-82
Timestamp: 2025-06-06T11:53:09.094Z
Learning: In ProTx serialization code (SERIALIZE_METHODS), version checks should use hardcoded maximum flags (/*is_basic_scheme_active=*/true, /*is_extended_addr=*/true) rather than deployment-based flags. This is because serialization code should be able to deserialize any structurally valid ProTx up to the maximum version the code knows how to handle, regardless of current consensus validity. Validation code, not serialization code, is responsible for checking whether a ProTx version is consensus-valid based on deployment status.

Learnt from: kwvg
PR: dashpay/dash#6530
File: src/validation.cpp:360-362
Timestamp: 2025-01-14T08:37:16.955Z
Learning: The UpdateTransactionsFromBlock() method in txmempool.cpp takes parameters in the order: vHashUpdate, ancestor_size_limit, ancestor_count_limit. The size limit comes before the count limit.

src/rpc/index_util.cpp (2)

Learnt from: kwvg
PR: dashpay/dash#6529
File: src/wallet/rpcwallet.cpp:3002-3003
Timestamp: 2025-02-14T15:19:17.218Z
Learning: The `GetWallet()` function calls in `src/wallet/rpcwallet.cpp` are properly validated with null checks that throw appropriate RPC errors, making additional validation unnecessary.

Learnt from: kwvg
PR: dashpay/dash#6718
File: test/functional/test_framework/test_framework.py:2102-2102
Timestamp: 2025-06-09T16:43:20.996Z
Learning: In the test framework consolidation PR (#6718), user kwvg prefers to limit functional changes to those directly related to MasternodeInfo, avoiding scope creep even for minor improvements like error handling consistency.

doc/release-notes.md (3)

Learnt from: kwvg
PR: dashpay/dash#6718
File: test/functional/test_framework/test_framework.py:2102-2102
Timestamp: 2025-06-09T16:43:20.996Z
Learning: In the test framework consolidation PR (#6718), user kwvg prefers to limit functional changes to those directly related to MasternodeInfo, avoiding scope creep even for minor improvements like error handling consistency.

Learnt from: kwvg
PR: dashpay/dash#6543
File: src/wallet/receive.cpp:240-251
Timestamp: 2025-02-06T14:34:30.466Z
Learning: Pull request #6543 is focused on move-only changes and refactoring, specifically backporting from Bitcoin. Behavior changes should be proposed in separate PRs.

Learnt from: PastaPastaPasta
PR: dashpay/dash#6564
File: contrib/containers/deploy/Dockerfile:1-1
Timestamp: 2025-02-11T19:25:05.487Z
Learning: The deploy container for Dash Core is designed to be minimal, requiring only basic container functionality without complex init systems or service management.

src/chainparams.cpp (4)

Learnt from: kwvg
PR: dashpay/dash#6543
File: src/wallet/receive.cpp:240-251
Timestamp: 2025-02-06T14:34:30.466Z
Learning: Pull request #6543 is focused on move-only changes and refactoring, specifically backporting from Bitcoin. Behavior changes should be proposed in separate PRs.

Learnt from: kwvg
PR: dashpay/dash#6718
File: test/functional/test_framework/test_framework.py:2102-2102
Timestamp: 2025-06-09T16:43:20.996Z
Learning: In the test framework consolidation PR (#6718), user kwvg prefers to limit functional changes to those directly related to MasternodeInfo, avoiding scope creep even for minor improvements like error handling consistency.

Learnt from: kwvg
PR: dashpay/dash#6530
File: src/validation.cpp:360-362
Timestamp: 2025-01-14T08:37:16.955Z
Learning: The UpdateTransactionsFromBlock() method in txmempool.cpp takes parameters in the order: vHashUpdate, ancestor_size_limit, ancestor_count_limit. The size limit comes before the count limit.

Learnt from: kwvg
PR: dashpay/dash#6665
File: src/evo/providertx.h:82-82
Timestamp: 2025-06-06T11:53:09.094Z
Learning: In ProTx serialization code (SERIALIZE_METHODS), version checks should use hardcoded maximum flags (/*is_basic_scheme_active=*/true, /*is_extended_addr=*/true) rather than deployment-based flags. This is because serialization code should be able to deserialize any structurally valid ProTx up to the maximum version the code knows how to handle, regardless of current consensus validity. Validation code, not serialization code, is responsible for checking whether a ProTx version is consensus-valid based on deployment status.

🧬 Code Graph Analysis (1)

src/rpc/index_util.cpp (1)

src/txdb.h (1)

• high (106-106)

🪛 LanguageTool

README.md

[grammar] ~92-~92: Use correct spacing
Context: ... be submitted to Dash Core's Transifex page. Translations are periodically pulled fr...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

doc/translation_process.md

[typographical] ~11-~11: To join two clauses or set off examples, consider using an em dash.
Context: ...o join the translation mailing list for announcements - see details below. ### Writing code wit...

(QB_NEW_EN_DASH_RULE_EM)

---

[grammar] ~11-~11: Use correct spacing
Context: ...ng list for announcements - see details below. ### Writing code with translations We use a...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~43-~43: Use correct spacing
Context: ... required to configure the command-line tool. You can find the Dash translation proje...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~45-~45: Use correct spacing
Context: ...an find the Dash translation project at https://explore.transifex.com/dash/dash/. ### Installing the Transifex client command...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~47-~47: There might be a mistake here.
Context: ...lling the Transifex client command-line tool The client is used to fetch updated transla...

(QB_NEW_EN_OTHER)

---

[grammar] ~48-~48: Use commas correctly
Context: ...updated translations. If you are having problems, or need more details, see <https://devel...

(QB_NEW_EN_OTHER_ERROR_IDS_33)

---

[grammar] ~48-~48: Use correct spacing
Context: ...ing problems, or need more details, see https://developers.transifex.com/docs/cli. For Linux and Mac `pip install trans...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~68-~68: Use correct spacing
Context: ...eleases-linuxmacwindows> for details on installation. The Transifex Dash project config file ...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~108-~108: Use articles correctly
Context: ... Questions and general assistance Check official forum at <https://www.dash.org/forum/fo...

(QB_NEW_EN_OTHER_ERROR_IDS_11)

doc/release-notes/dash/release-notes-22.1.2.md

[grammar] ~1-~1: Use correct spacing
Context: # Dash Core version v22.1.2 This is a new minor version release, br...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[style] ~3-~3: This is not the usual sequence for adjectives that have no special emphasis.
Context: # Dash Core version v22.1.2 This is a new minor version release, bringing various bugfi...

(EN_ADJ_ORDER)

---

[grammar] ~3-~3: There might be a problem here.
Context: ...s a new minor version release, bringing various bugfixes and performance improvements. This rele...

(QB_NEW_EN_MERGED_MATCH)

---

[grammar] ~4-~4: Use correct spacing
Context: ...is optional for all nodes, although recommended. Please report bugs using the issue trac...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~6-~6: There might be a problem here.
Context: ... report bugs using the issue tracker at GitHub: https://github.com/dashpay/dash/issues # Upgrading and downgrading ## How to Up...

(QB_NEW_EN_MERGED_MATCH)

---

[grammar] ~11-~11: Use correct spacing
Context: .../dashpay/dash/issues> # Upgrading and downgrading ## How to Upgrade If you are running an o...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~13-~13: Use correct spacing
Context: ... # Upgrading and downgrading ## How to Upgrade If you are running an older version, sh...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~15-~15: Use correct spacing
Context: ...ersion, shut it down. Wait until it has completely shut down (which might take a few minutes fo...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~16-~16: Use correct spacing
Context: ...w minutes for older versions), then run the installer (on Windows) or just copy over /Applica...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~17-~17: Use correct spacing
Context: ...opy over /Applications/Dash-Qt (on Mac) or dashd/dash-qt (on Linux). ## Downgrade warning ### ...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~18-~18: Use correct spacing
Context: ...s/Dash-Qt (on Mac) or dashd/dash-qt (on Linux). ## Downgrade warning ### Downgrade to a v...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~20-~20: Use correct spacing
Context: ...dashd/dash-qt (on Linux). ## Downgrade warning ### Downgrade to a version < v22.0.0 Downg...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~22-~22: There might be a mistake here.
Context: ...e warning ### Downgrade to a version < v22.0.0 Downgrading to a version older than v22...

(QB_NEW_EN_OTHER)

---

[grammar] ~24-~24: Use commas correctly
Context: ...a version older than v22.0.0 may not be supported, and will likely require a reindex. # Re...

(QB_NEW_EN_OTHER_ERROR_IDS_33)

---

[grammar] ~24-~24: Use correct spacing
Context: ... than v22.0.0 may not be supported, and will likely require a reindex. # Release Notes Qu...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~25-~25: Use correct spacing
Context: ...be supported, and will likely require a reindex. # Release Notes Quorum Rotation Improvem...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~27-~27: Use correct spacing
Context: ...ll likely require a reindex. # Release Notes Quorum Rotation Improvements ----------...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~29-~29: There might be a problem here.
Context: ...ndex. # Release Notes Quorum Rotation Improvements ---------------------------- - Optimized quorum rotationinfo RPC and `GETQUORU...

(QB_NEW_EN_MERGED_MATCH)

---

[grammar] ~33-~33: Use correct spacing
Context: ...proving result accuracy and compactness (dash#6625). Deployment and CI Fixes ---------------...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~35-~35: Use correct spacing
Context: ...actness (dash#6625). Deployment and CI Fixes ----------------------- - Pinned QEMU version to avoid segmentati...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~38-~38: Use correct spacing
Context: ...entation faults during container builds (dash#6586). Performance Improvements --------------...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~40-~40: Use correct spacing
Context: ...tainer builds (dash#6586). Performance Improvements ------------------------ - Improved the performance of determinist...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~43-~43: Use correct spacing
Context: ...eding up RPC calls such as protx diff (dash#6581). Coinjoin Tests Stability --------------...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~45-~45: Use correct spacing
Context: ...rotx diff(dash#6581). Coinjoin Tests Stability ------------------------ - Resolved potential deadlock incoinjoi...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~48-~48: Use correct spacing
Context: ...ccur outside critical wallet lock scope (dash#6593). Minor Build and Test Fixes ------------...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~50-~50: Use correct spacing
Context: ...cope (dash#6593). Minor Build and Test Fixes -------------------------- - Fixed assertion edge case for coinbase ...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~54-~54: Use correct spacing
Context: ...YING file and Debian packaging metadata (dash#6599). P2P Changes ----------- - cycleHash ...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~56-~56: There might be a problem here.
Context: ...an packaging metadata (dash#6599). P2P Changes ----------- - cycleHash field in isdlock message will now represent a ...

(QB_NEW_EN_MERGED_MATCH)

---

[grammar] ~59-~59: Use correct spacing
Context: ...P protocol version was bumped to 70237. (#6608) # v22.1.2 Change log See detailed [set o...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~61-~61: Use correct spacing
Context: ...ed to 70237. (#6608) # v22.1.2 Change log See detailed [set of changes][set-of-ch...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~63-~63: There might be a problem here.
Context: ...22.1.2 Change log See detailed [set of changes][set-of-changes]. # Credits Thanks to everyone who directly contrib...

(QB_NEW_EN_MERGED_MATCH)

---

[grammar] ~67-~67: Use correct spacing
Context: ...eryone who directly contributed to this release: - Kittywhiskers Van Gogh - Konstantin Aki...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~73-~73: Use correct spacing
Context: ...dysseas Gabrielides - PastaPastaPasta - UdjinM6 As well as everyone that submitted issu...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~75-~75: Add a comma
Context: ...ne that submitted issues, reviewed pull requests and helped debug the release candidates...

(QB_NEW_EN_OTHER_ERROR_IDS_22)

---

[grammar] ~75-~75: Use correct spacing
Context: ...tted issues, reviewed pull requests and helped debug the release candidates. # Older releas...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~76-~76: Use correct spacing
Context: ...l requests and helped debug the release candidates. # Older releases These releases are cons...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~78-~78: Use correct spacing
Context: ... debug the release candidates. # Older releases These releases are considered obsolete....

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~80-~80: Use correct spacing
Context: ...bsolete. Old release notes can be found here: - [v22.1.1](https://github.com/dashpay/das...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

doc/release-notes.md

[grammar] ~1-~1: Use correct spacing
Context: # Dash Core version v22.1.3 This is a new minor version release, br...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~29-~29: Use correct spacing
Context: ...equire a reindex. # Release Notes Bug Fixes ---------- - Fixed crash when processing invalid mas...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~32-~32: Use correct spacing
Context: ...fe assertion with proper error handling (dash#6740). RPC and Logging Improvements ----------...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~34-~34: Use correct spacing
Context: ... handling (dash#6740). RPC and Logging Improvements ---------------------------- - Fixed misleading error logs that were t...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~37-~37: Use correct spacing
Context: ...g log noise and preventing false alarms (dash#6744). Performance Improvements --------------...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~39-~39: Use correct spacing
Context: ... false alarms (dash#6744). Performance Improvements ------------------------ - Optimized versionbits calculation to av...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~42-~42: There might be a mistake here.
Context: ...s ------------------------ - Optimized versionbits calculation to avoid unnecessary comput...

(QB_NEW_EN_OTHER)

---

[grammar] ~42-~42: Use correct spacing
Context: ...mance during blockchain reorganizations (dash#6632). Documentation Updates -----------------...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~44-~44: Use correct spacing
Context: ...ganizations (dash#6632). Documentation Updates --------------------- - Updated translation documentation with ...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~47-~47: Use correct spacing
Context: ...s properly access translation resources (dash#6739). # v22.1.3 Change log See detailed [set o...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~49-~49: Use correct spacing
Context: ...sources (dash#6739). # v22.1.3 Change log See detailed [set of changes][set-of-ch...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

---

[grammar] ~51-~51: There might be a problem here.
Context: ...22.1.3 Change log See detailed [set of changes][set-of-changes]. # Credits Thanks to everyone who directly contrib...

(QB_NEW_EN_MERGED_MATCH)

---

[grammar] ~55-~55: Use correct spacing
Context: ...eryone who directly contributed to this release: - Jorge Maldonado Ventura - Konstantin Ak...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

🪛 GitHub Actions: Check Merge Fast-Forward Only

configure.ac

[error] 1-1: Merge conflict detected in configure.ac. Automatic merge failed; conflicts must be resolved manually.

🪛 markdownlint-cli2 (0.17.2)

doc/release-notes/dash/release-notes-22.1.2.md

29-29: Heading style
Expected: atx; Actual: setext

(MD003, heading-style)

---

35-35: Heading style
Expected: atx; Actual: setext

(MD003, heading-style)

---

40-40: Heading style
Expected: atx; Actual: setext

(MD003, heading-style)

---

45-45: Heading style
Expected: atx; Actual: setext

(MD003, heading-style)

---

50-50: Heading style
Expected: atx; Actual: setext

(MD003, heading-style)

---

56-56: Heading style
Expected: atx; Actual: setext

(MD003, heading-style)

doc/release-notes.md

30-30: Heading style
Expected: setext; Actual: atx

(MD003, heading-style)

---

36-36: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

42-42: Heading style
Expected: setext; Actual: atx

(MD003, heading-style)

---

47-47: Heading style
Expected: setext; Actual: atx

(MD003, heading-style)

---

50-50: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🔇 Additional comments (17)

src/masternode/payments.cpp (1)

127-134: Excellent defensive programming improvement.

This change properly handles cases where ExtractDestination fails by providing a fallback to log the raw hex string instead of asserting. This prevents potential crashes while still providing useful debugging information.

src/rpc/index_util.cpp (5)

29-29: LGTM - Streamlined error handling.

The direct return of the database operation result simplifies the code without losing functionality.

---

39-39: LGTM - Consistent error handling pattern.

The simplified return logic maintains the same functionality while improving readability.

---

59-59: LGTM - Streamlined mempool error handling.

The direct return pattern is consistent with other functions in this file.

---

83-83: LGTM - Simplified database read operation.

The direct return of the database operation result maintains functionality while improving code clarity.

---

95-95: LGTM - Consistent with other index functions.

The simplified return logic follows the same pattern as other functions in this file.

doc/translation_process.md (6)

11-11: LGTM - Updated Transifex project URL.

The URL has been updated to the current Transifex format, ensuring users can access the correct translation project page.

---

43-43: LGTM - Updated Transifex signup URL.

The signup URL has been updated to the current Transifex application URL format.

---

45-45: LGTM - Consistent Transifex project URL.

This URL update is consistent with the earlier change and maintains proper documentation.

---

48-48: LGTM - Updated Transifex documentation URL.

The documentation URL has been updated to the current Transifex developer documentation format.

---

68-68: LGTM - Updated Transifex CLI documentation URL.

The URL update points to the current Transifex CLI documentation and GitHub releases page.

---

108-108: LGTM - Updated Dash forum URL.

The forum URL has been updated to the current format for Dash worldwide collaboration.

README.md (1)

92-92: LGTM - Updated Transifex project URL.

The URL has been updated to the current Transifex format, consistent with the changes in doc/translation_process.md. This ensures users can access the correct translation project page.

configure.ac (1)

5-5: Version increment looks correct for v22.1.3 release.

The build number increment from 2 to 3 is appropriate for this patch release.

However, note that the pipeline failure indicates a merge conflict in this file that needs to be resolved before the PR can be merged.

src/versionbits.cpp (1)

76-77: Excellent performance optimization with early return.

This change appropriately avoids expensive calculateStartHeight() computation and the forward state computation loop when vToCompute is empty, indicating no blocks require state computation. The placement is optimal - after retrieving the cached state but before expensive operations.

This optimization should improve performance particularly during blockchain reorganizations as mentioned in the release notes.

src/chainparams.cpp (2)

420-424: Same checkpoint sanity check for testnet

Ensure the testnet nMinimumChainWork / defaultAssumeValid pair correspond to height 1 254 997 and that the work value is monotonic (≥ previous value).

Same verification procedure as for mainnet applies.

---

221-226: Manual verification needed for new checkpoints & chain-work

The automated check couldn’t run dash-cli in this environment. Please confirm both values against a fully-synced mainnet node:

• That defaultAssumeValid really is the block hash at height 2301632
• That nMinimumChainWork equals or exceeds the chainwork reported for that block

You can verify with:

dash-cli getblockhash 2301632
dash-cli getblockheader $(dash-cli getblockhash 2301632) | jq .chainwork

[UdjinM6]

LGTM, one suggestion

[UdjinM6]

utACK 9ec8e66

[kwvg]

utACK 9ec8e66

[knst]

LGTM 9ec8e66