feat: proactively push recovered signatures; fully connect instantsend quorums for recovered sigs #6967

PastaPastaPasta · 2025-11-13T01:58:10Z

Please remove the italicized help prompts before submitting or merging

Provide a general summary of your changes in the Title above

Pull requests without a rationale and clear improvement may be closed
immediately.

Please provide clear motivation for your patch and explain how it improves
Dash Core user experience or Dash Core developer experience
significantly:

Any test improvements or new tests that improve coverage are always welcome.
All other changes should have accompanying unit tests (see src/test/) or
functional tests (see test/). Contributors should note which tests cover
modified code. If no tests exist for a region of modified code, new tests
should accompany the change.
Bug fixes are most welcome when they come with steps to reproduce or an
explanation of the potential issue as well as reasoning for the way the bug
was fixed.
Features are welcome, but might be rejected due to design or scope issues.
If a feature is based on a lot of dependencies, contributors should first
consider building the system outside of Dash Core, if possible.

Issue being fixed or feature implemented

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.

What was done?

Describe your changes in detail

How Has This Been Tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran
to see how your change affects other areas of the code, etc.

Breaking Changes

Please describe any breaking changes your code introduces

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

github-actions · 2025-11-13T01:58:54Z

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

refactor: separate network and consensus logic 2a/N [signing] #6992 - refactor: separate network and consensus logic 2a/N [signing]

Please coordinate with the authors of these PRs to avoid merge conflicts.

DashCoreAutoGuix · 2025-11-13T02:00:06Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.f172589d. A new comment will be made when the image is pushed.

github-actions · 2025-11-13T02:16:38Z

This pull request has conflicts, please rebase.

DashCoreAutoGuix · 2025-11-13T03:42:52Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.f172589d. The image should be on dockerhub soon.

DashCoreAutoGuix · 2025-11-13T03:44:04Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.10b47ca5. A new comment will be made when the image is pushed.

DashCoreAutoGuix · 2025-11-13T04:47:07Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.10b47ca5. The image should be on dockerhub soon.

DashCoreAutoGuix · 2025-11-14T15:12:06Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.3c679369. A new comment will be made when the image is pushed.

DashCoreAutoGuix · 2025-11-14T16:18:51Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.3c679369. The image should be on dockerhub soon.

DashCoreAutoGuix · 2025-11-17T15:38:05Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.2e8ac6a7. A new comment will be made when the image is pushed.

DashCoreAutoGuix · 2025-11-17T16:47:57Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.2e8ac6a7. The image should be on dockerhub soon.

coderabbitai · 2025-11-18T14:50:39Z

Walkthrough

This pull request threads a new proactive relay flag through recovered-signature handling. CSigningManager::ProcessRecoveredSig gains a NodeId from parameter to determine proactive_relay. Notification and relay APIs are updated to accept the flag: validation signals, sigshares, active/zmq notifiers, and PeerManager::RelayRecoveredSig now accept/provide proactive_relay; RelayRecoveredSig also now takes a full CRecoveredSig. Quorum relay selection logic in llmq utils was simplified to use connection sets directly. Multiple call sites were updated accordingly across signing, networking, validation, and ZMQ code.

Sequence Diagram(s)

sequenceDiagram
    participant SM as CSigningManager
    participant VS as CMainSignals / ValidationInterface
    participant SSM as CSigSharesManager
    participant PM as PeerManager
    participant ZMQ as ZMQNotifiers

    rect rgb(230,240,255)
    Note over SM: Recovered sig arrives
    SM->>SM: ProcessRecoveredSig(sig, peerman, from)
    SM->>SM: compute proactive_relay (from, llmqType)
    SM->>VS: NotifyRecoveredSig(sig, id, proactive_relay)
    end

    rect rgb(240,230,255)
    VS->>SSM: NotifyRecoveredSig(sig, proactive_relay)
    SSM->>PM: RelayRecoveredSig(sig, proactive_relay)
    end

    rect rgb(255,240,230)
    alt proactive_relay == true
        PM->>PM: Proactively broadcast QSIGREC to peers wanting rec sigs
    else
        PM->>PM: Relay via inventory (MSG_QUORUM_RECOVERED_SIG)
    end
    end

    rect rgb(230,255,240)
    PM->>ZMQ: NotifyRecoveredSig(sig, proactive_relay)
    ZMQ->>ZMQ: Publish to subscribers (hash/raw as configured)
    end

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Areas requiring extra attention during review:

src/llmq/signing.cpp / src/llmq/signing.h: correctness of from threading and proactive_relay computation (which llmq types are excluded).
src/net_processing.cpp / src/net_processing.h: new proactive broadcast path (QSIGREC) vs. inventory relay; peer filtering and early-return behavior.
src/llmq/signing_shares.* and src/masternode/active/notificationinterface.*: consistent signature changes and locking annotations for NotifyRecoveredSig.
src/llmq/utils.cpp: changes to quorum relay member selection and removal of separate relayMembers logic.
src/validationinterface.* and src/zmq/*: ensure all notifier interfaces and implementations correctly accept and forward the new boolean parameter.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description consists entirely of template placeholders and help text instructing the author to remove them before submission, providing no actual context about the changes, rationale, testing, or breaking changes.	Replace template text with a concrete description explaining the rationale for proactive signature pushing, the specific problem it solves, how it was tested, and any breaking changes introduced.
Docstring Coverage	⚠️ Warning	Docstring coverage is 5.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main changes: proactively pushing recovered signatures and fully connecting instantsend quorums, which aligns with the extensive signature propagation and relay logic changes shown throughout the changeset.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e8ac6a and e404e67.

📒 Files selected for processing (1)

src/llmq/utils.cpp (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-10-02T18:29:54.756Z

Learnt from: kwvg
Repo: dashpay/dash PR: 6840
File: src/net_processing.cpp:2882-2886
Timestamp: 2025-10-02T18:29:54.756Z
Learning: Across net_processing.cpp, once LLMQContext (m_llmq_ctx) is asserted non-null, its subcomponents (e.g., isman, qdkgsman, quorum_block_processor) are treated as initialized and used without extra null checks.

Applied to files:

src/llmq/utils.cpp

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

GitHub Check: mac-build / Build source
GitHub Check: linux64_tsan-build / Build source
GitHub Check: linux64_sqlite-build / Build source
GitHub Check: linux64_ubsan-build / Build source
GitHub Check: linux64_fuzz-build / Build source
GitHub Check: linux64-build / Build source
GitHub Check: win64-build / Build source
GitHub Check: linux64_nowallet-build / Build source
GitHub Check: arm-linux-build / Build source
GitHub Check: Lint / Run linters

🔇 Additional comments (1)

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

Provide your own instructions using the high_level_summary_instructions setting.
Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (3)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between caf5010 and 2e8ac6a.

📒 Files selected for processing (17)

src/llmq/signing.cpp (4 hunks)
src/llmq/signing.h (1 hunks)
src/llmq/signing_shares.cpp (3 hunks)
src/llmq/signing_shares.h (1 hunks)
src/llmq/utils.cpp (1 hunks)
src/masternode/active/notificationinterface.cpp (1 hunks)
src/masternode/active/notificationinterface.h (1 hunks)
src/net_processing.cpp (2 hunks)
src/net_processing.h (1 hunks)
src/validationinterface.cpp (1 hunks)
src/validationinterface.h (2 hunks)
src/zmq/zmqabstractnotifier.cpp (1 hunks)
src/zmq/zmqabstractnotifier.h (1 hunks)
src/zmq/zmqnotificationinterface.cpp (1 hunks)
src/zmq/zmqnotificationinterface.h (1 hunks)
src/zmq/zmqpublishnotifier.cpp (2 hunks)
src/zmq/zmqpublishnotifier.h (2 hunks)

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: kwvg
Repo: dashpay/dash PR: 6761
File: src/chainlock/signing.cpp:247-250
Timestamp: 2025-07-29T14:32:48.369Z
Learning: In PR #6761, kwvg acknowledged a null pointer check issue in ChainLockSigner::Cleanup() method but deferred it to follow-up, consistent with the pattern of avoiding scope creep in refactoring PRs.

📚 Learning: 2025-07-15T14:53:04.819Z

Learnt from: knst
Repo: dashpay/dash PR: 6691
File: src/test/llmq_params_tests.cpp:148-151
Timestamp: 2025-07-15T14:53:04.819Z
Learning: In the Dash Core LLMQ implementation, signingActiveQuorumCount is never 0 in the actual parameters defined in params.h, making division by zero scenarios unrealistic in the max_cycles() function.

Applied to files:

src/llmq/signing.cpp

📚 Learning: 2025-10-02T18:29:54.756Z

Learnt from: kwvg
Repo: dashpay/dash PR: 6840
File: src/net_processing.cpp:2882-2886
Timestamp: 2025-10-02T18:29:54.756Z
Learning: Across net_processing.cpp, once LLMQContext (m_llmq_ctx) is asserted non-null, its subcomponents (e.g., isman, qdkgsman, quorum_block_processor) are treated as initialized and used without extra null checks.

Applied to files:

src/llmq/utils.cpp

📚 Learning: 2025-08-19T15:08:00.835Z

Learnt from: knst
Repo: dashpay/dash PR: 6692
File: src/llmq/commitment.cpp:54-60
Timestamp: 2025-08-19T15:08:00.835Z
Learning: In Dash Core, llmq_params.size == 1 is used only for regtest environments, not on public networks, which significantly reduces the risk profile of code paths specific to single-member quorums.

Applied to files:

src/llmq/utils.cpp

🧬 Code graph analysis (15)

src/net_processing.h (3)

src/masternode/active/notificationinterface.h (6)

src/llmq/signing.h (1)

src/zmq/zmqpublishnotifier.h (7)

src/zmq/zmqabstractnotifier.cpp (5)

src/validationinterface.h (7)

src/zmq/zmqnotificationinterface.cpp (6)

src/zmq/zmqabstractnotifier.h (7)

src/llmq/signing_shares.h (7)

src/zmq/zmqpublishnotifier.cpp (6)

src/zmq/zmqnotificationinterface.h (7)

src/masternode/active/notificationinterface.cpp (6)

src/validationinterface.cpp (6)

src/llmq/signing.cpp (1)

src/llmq/signing_shares.cpp (6)

🪛 GitHub Actions: Clang Diff Format Check

src/llmq/signing_shares.h

[error] 1-1: Clang format differences found in src/llmq/signing_shares.h. Run the clang-format-diff tool or clang-format to fix formatting changes.

src/masternode/active/notificationinterface.cpp

[error] 1-1: Clang format differences found in src/masternode/active/notificationinterface.cpp. Run the clang-format-diff tool or clang-format to fix formatting changes.

src/llmq/signing.cpp

[error] 1-1: Clang format differences found in src/llmq/signing.cpp. Run the clang-format-diff tool or clang-format to fix formatting changes.

🔇 Additional comments (16)

coderabbitai · 2025-11-18T14:50:42Z

src/llmq/signing_shares.h

                           bool allowDiffMsgHashSigning = false) EXCLUSIVE_LOCKS_REQUIRED(!cs_pendingSigns, !cs);

-    void NotifyRecoveredSig(const std::shared_ptr<const CRecoveredSig>& sig) const EXCLUSIVE_LOCKS_REQUIRED(!cs);
+    void NotifyRecoveredSig(const std::shared_ptr<const CRecoveredSig>& sig, bool proactive_relay) const EXCLUSIVE_LOCKS_REQUIRED(!cs);


⚠️ Potential issue | 🟡 Minor

Recovered‑sig notification wiring is correct; fix clang‑format to unbreak CI

The new NotifyRecoveredSig(const std::shared_ptr<const CRecoveredSig>& sig, bool proactive_relay) const EXCLUSIVE_LOCKS_REQUIRED(!cs) overload is consistent with its implementation in signing_shares.cpp and with the locking strategy (no cs held while calling PeerManager::RelayRecoveredSig). Semantics look good.

CI is currently failing on src/llmq/signing_shares.h due to a clang‑format diff, though. Please run the project’s clang‑format tooling on this file (or at least around this declaration) and commit the resulting formatting changes so the pipeline passes.

🤖 Prompt for AI Agents

In src/llmq/signing_shares.h around line 452, the new overload declaration is correctly implemented but its formatting doesn't match the project's clang-format rules and is causing CI failures; run the project's clang-format tool (or apply the repo's clang-format style) to reformat this file or at least the vicinity of this declaration, update the header with the formatted result, and commit that change so the CI clang-format check passes.

coderabbitai · 2025-11-18T14:50:42Z

src/masternode/active/notificationinterface.cpp

+void ActiveNotificationInterface::NotifyRecoveredSig(const std::shared_ptr<const llmq::CRecoveredSig>& sig, bool proactive_relay)
 {
-    m_active_ctx.shareman->NotifyRecoveredSig(sig);
+    m_active_ctx.shareman->NotifyRecoveredSig(sig, proactive_relay);


⚠️ Potential issue | 🟡 Minor

Fix clang-format issues.

The CI pipeline reports formatting differences in this file. Please run clang-format to resolve the formatting issues before merging.

Run the following command to fix formatting:

#!/bin/bash # Format the file according to project style clang-format -i src/masternode/active/notificationinterface.cpp

🤖 Prompt for AI Agents

In src/masternode/active/notificationinterface.cpp around lines 32 to 34, the file fails CI due to clang-format style differences; run clang-format -i on that file to reformat it (or apply your project's clang-format settings) so the NotifyRecoveredSig function and surrounding whitespace/indentation match project style, then re-run clang-format or the CI linter and commit the updated file.

src/llmq/utils.cpp

DashCoreAutoGuix · 2025-11-19T21:02:04Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.e404e679. A new comment will be made when the image is pushed.

DashCoreAutoGuix · 2025-11-19T22:07:28Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.e404e679. The image should be on dockerhub soon.

…ho performed recovery

… connections for all members

PastaPastaPasta added the guix-build label Nov 13, 2025

github-actions bot added the needs rebase label Nov 13, 2025

PastaPastaPasta force-pushed the feat/proactively-push-recsig branch from f172589 to 10b47ca Compare November 13, 2025 02:23

github-actions bot removed the needs rebase label Nov 13, 2025

PastaPastaPasta changed the title ~~Feat/proactively push recsig~~ feat: proactively push recovered signatures; fully connect instantsend quorums for recovered sigs Nov 13, 2025

PastaPastaPasta force-pushed the feat/proactively-push-recsig branch from 10b47ca to 3c67936 Compare November 14, 2025 15:10

PastaPastaPasta force-pushed the feat/proactively-push-recsig branch from 3c67936 to 2e8ac6a Compare November 17, 2025 15:37

PastaPastaPasta marked this pull request as ready for review November 18, 2025 14:40

coderabbitai bot reviewed Nov 18, 2025

View reviewed changes

This was referenced Nov 19, 2025

refactor: avoid return by reference and prefer return by value #6955

Open

refactor: separate network and consensus logic 2a/N [signing] #6992

Open

UdjinM6 reviewed Nov 19, 2025

View reviewed changes

src/llmq/utils.cpp Outdated Show resolved Hide resolved

PastaPastaPasta added 4 commits November 21, 2025 11:42

feat: proactively relay recovered signatures when we are the member w…

eb6c2a1

…ho performed recovery

feat: enhance recovered signature propagation by leveraging full-mesh…

a6c3da6

… connections for all members

fix: proper include syntax

1f95f07

fix: avoid improper dual way connection attempts

7e782ff

PastaPastaPasta force-pushed the feat/proactively-push-recsig branch from e404e67 to 7e782ff Compare November 21, 2025 17:42

feat: proactively push recovered signatures; fully connect instantsend quorums for recovered sigs #6967

Are you sure you want to change the base?

feat: proactively push recovered signatures; fully connect instantsend quorums for recovered sigs #6967

Conversation

PastaPastaPasta commented Nov 13, 2025

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Uh oh!

github-actions bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Potential Merge Conflicts Detected

Uh oh!

DashCoreAutoGuix commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

DashCoreAutoGuix commented Nov 13, 2025

Uh oh!

DashCoreAutoGuix commented Nov 13, 2025

Uh oh!

DashCoreAutoGuix commented Nov 13, 2025

Uh oh!

DashCoreAutoGuix commented Nov 14, 2025

Uh oh!

DashCoreAutoGuix commented Nov 14, 2025

Uh oh!

DashCoreAutoGuix commented Nov 17, 2025

Uh oh!

DashCoreAutoGuix commented Nov 17, 2025

Uh oh!

coderabbitai bot commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Sequence Diagram(s)

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DashCoreAutoGuix commented Nov 19, 2025

Uh oh!

DashCoreAutoGuix commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Nov 13, 2025 •

edited

Loading

coderabbitai bot commented Nov 18, 2025 •

edited

Loading