Skip to content

fix: adjust condition to detect suitable pending masternodes #6983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: adjust condition to detect suitable pending masternodes #6983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/net.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3454,13 +3454,12 @@ void CConnman::ThreadOpenMasternodeConnections(CDeterministicMNManager& dmnman,
// Check if we should connect to this masternode
// We already hold m_nodes_mutex here, so check m_masternode_connection directly
if (dmn && !connectedNodes.count(dmn->pdmnState->netInfo->GetPrimary())) {
if (const CNode* pnode = FindNode(dmn->pdmnState->netInfo->GetPrimary())) {
if (!pnode->m_masternode_connection) {
LogPrint(BCLog::NET_NETCONN, "CConnman::%s -- opening pending masternode connection to %s, service=%s\n",
_func_, dmn->proTxHash.ToString(),
dmn->pdmnState->netInfo->GetPrimary().ToStringAddrPort());
return dmn;
}
const CNode* pnode = FindNode(dmn->pdmnState->netInfo->GetPrimary(), /*fExcludeDisconnecting=*/false);
if (pnode == nullptr || (!pnode->m_masternode_connection && !pnode->fDisconnect)) {
LogPrint(BCLog::NET_NETCONN, "CConnman::%s -- opening pending masternode connection to %s, service=%s\n",
_func_, dmn->proTxHash.ToString(),
dmn->pdmnState->netInfo->GetPrimary().ToStringAddrPort());
return dmn;
}
}
}
Expand Down
Loading